From db9bf11453ca27feea94d2b1501a2b3b068ce73e Mon Sep 17 00:00:00 2001 From: Titus Mombaecher <titus.mombacher@cern.ch> Date: Wed, 2 Apr 2025 12:30:15 +0200 Subject: [PATCH 1/3] add binds for monitoring 2025 --- .../python/Hlt2Conf/settings/hlt2_binds.py | 31 +++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/Hlt/Hlt2Conf/python/Hlt2Conf/settings/hlt2_binds.py b/Hlt/Hlt2Conf/python/Hlt2Conf/settings/hlt2_binds.py index d508de0b5f8..e8c28ac86ed 100644 --- a/Hlt/Hlt2Conf/python/Hlt2Conf/settings/hlt2_binds.py +++ b/Hlt/Hlt2Conf/python/Hlt2Conf/settings/hlt2_binds.py @@ -142,6 +142,37 @@ def config_pp_2025_nominal(): ): yield +@contextmanager +def config_pp_2025_with_monitoring(): + """ContextManagerGenerator for default 2025 proton-proton HLT2 configuration binds with monitoring. + + Depending on the actual data and control flow, using this convenience function + may emits some warnings about something not called within a bind. This is harmless + if the corresponding component is not configured on purpose - like a default HLT1 + filter code which is not used when only the reconstruction is run. + + Use this function like this:: + + with config_pp_2025_with_monitoring(): + run_reconstruction() + """ + with ( + config_pp_2025(), + add_hlt2_rich.bind(with_UT=True, track_types=["Long"]), + get_default_out_track_types_for_light_reco.bind(skip_UT=False), + get_monitoring_track_types_for_light_reco.bind(skip_UT=False), + convert_tracks_to_v3_from_v1.bind( + track_types=["Long", "Upstream", "Downstream", "Ttrack"] + ), + PrKalmanFilter.bind(FillFitResult=True), + PrKalmanFilter_Downstream.bind(FillFitResult=True), + PrKalmanFilter_Upstream.bind(FillFitResult=True), + PrKalmanFilter_Seed.bind(FillFitResult=True), + PrKalmanFilter_Velo.bind(FillFitResult=True), + ): + yield + + ############################# ### 2024 HLT2 pp settings ### -- GitLab From 43c1bc716b0a0fe90cec7f430104b13cfc3a3741 Mon Sep 17 00:00:00 2001 From: Gitlab CI <noreply@cern.ch> Date: Wed, 2 Apr 2025 10:32:36 +0000 Subject: [PATCH 2/3] pre-commit fixes patch generated by https://gitlab.cern.ch/lhcb/Moore/-/jobs/54049077 --- Hlt/Hlt2Conf/python/Hlt2Conf/settings/hlt2_binds.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Hlt/Hlt2Conf/python/Hlt2Conf/settings/hlt2_binds.py b/Hlt/Hlt2Conf/python/Hlt2Conf/settings/hlt2_binds.py index e8c28ac86ed..10cb7b1ab95 100644 --- a/Hlt/Hlt2Conf/python/Hlt2Conf/settings/hlt2_binds.py +++ b/Hlt/Hlt2Conf/python/Hlt2Conf/settings/hlt2_binds.py @@ -142,6 +142,7 @@ def config_pp_2025_nominal(): ): yield + @contextmanager def config_pp_2025_with_monitoring(): """ContextManagerGenerator for default 2025 proton-proton HLT2 configuration binds with monitoring. @@ -173,7 +174,6 @@ def config_pp_2025_with_monitoring(): yield - ############################# ### 2024 HLT2 pp settings ### ############################# -- GitLab From d0cdec28cab41ea29ca18cb977857176267be619 Mon Sep 17 00:00:00 2001 From: Titus Mombaecher <titus.mombacher@cern.ch> Date: Wed, 2 Apr 2025 15:30:12 +0200 Subject: [PATCH 3/3] remove unnecessary binds --- Hlt/Hlt2Conf/python/Hlt2Conf/settings/hlt2_binds.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Hlt/Hlt2Conf/python/Hlt2Conf/settings/hlt2_binds.py b/Hlt/Hlt2Conf/python/Hlt2Conf/settings/hlt2_binds.py index 10cb7b1ab95..459e8bdd312 100644 --- a/Hlt/Hlt2Conf/python/Hlt2Conf/settings/hlt2_binds.py +++ b/Hlt/Hlt2Conf/python/Hlt2Conf/settings/hlt2_binds.py @@ -159,9 +159,7 @@ def config_pp_2025_with_monitoring(): """ with ( config_pp_2025(), - add_hlt2_rich.bind(with_UT=True, track_types=["Long"]), - get_default_out_track_types_for_light_reco.bind(skip_UT=False), - get_monitoring_track_types_for_light_reco.bind(skip_UT=False), + add_hlt2_rich.bind(track_types=["Long"]), convert_tracks_to_v3_from_v1.bind( track_types=["Long", "Upstream", "Downstream", "Ttrack"] ), -- GitLab