Cleanup for 2015 Moore stack

Cleanups

• Move imported packages from Moore v24r3 to Hlt (see Hlt!635 (merged))
• Remove obsolete cmt files
• Remove obsolete *Sys/CMakeLists.txt and tests
• Add .gitignore
• Update L0App tests (cherry pick of !52 (merged), and part of !120 (merged))
• Update reference for HLT1 PrChecker
• Fix some tests (see also !22 (merged)) and remove failing tests not needed for legacy branch
  This is a maintenance branch for the 2015 legacy Moore version. As such, running from trheshold settings is no longer necessary or actively supported, so the corresponding tests are removed. Other removed tests are those running on old DB tags or simulation versions.
• Add copyright and copyright check

New features and tests

• Add functor cache for all 2015 MC TCKs
• Add L0 and HLT (non-split) tests for 2015 MC TCK (0x411400a2)
• Add timing table to L0App (cherry pick of !49 (merged))
• Add Generator FSRs (cherry pick of Hlt!170 (merged), !47 (merged) and parts of !120 (merged))

Goes together with Rec!2133 (merged) Phys!739 (merged) Hlt!635 (merged)

added all-slots cleanup labels

mentioned in merge request Hlt!635 (merged)

• [2020-07-07 00:09] Validation started with lhcb-reco15-patches#552
• [2020-07-08 17:26] Validation started with lhcb-reco15-patches#553
• [2020-07-11 00:12] Validation started with lhcb-reco15-patches#554
• [2020-07-18 00:14] Validation started with lhcb-reco15-patches#555
• [2020-07-25 00:07] Validation started with lhcb-reco15-patches#556
• [2020-08-01 00:09] Validation started with lhcb-reco15-patches#557
• [2020-08-06 00:11] Validation started with lhcb-reco15-patches#558
• [2020-08-13 00:13] Validation started with lhcb-reco15-patches#559
• [2020-08-14 00:09] Validation started with lhcb-reco15-patches#560
• [2020-08-21 00:10] Validation started with lhcb-reco15-patches#561
• [2020-08-28 00:08] Validation started with lhcb-reco15-patches#562
• [2020-09-04 00:13] Validation started with lhcb-reco15-patches#563
• [2020-09-11 00:12] Validation started with lhcb-reco15-patches#564
• [2020-09-18 00:13] Validation started with lhcb-reco15-patches#565
• [2020-09-24 00:09] Validation started with lhcb-reco15-patches#566
• [2020-09-25 00:08] Validation started with lhcb-reco15-patches#567
• [2020-09-26 00:08] Validation started with lhcb-reco15-patches#568
• [2020-10-03 00:08] Validation started with lhcb-reco15-patches#569
• [2020-10-10 00:08] Validation started with lhcb-reco15-patches#570
• [2020-10-17 00:07] Validation started with lhcb-reco15-patches#571
• [2020-10-24 00:08] Validation started with lhcb-reco15-patches#572
• [2020-10-26 00:12] Validation started with lhcb-reco15-patches#573
• [2020-11-02 00:11] Validation started with lhcb-reco15-patches#574
• [2020-11-09 00:07] Validation started with lhcb-reco15-patches#575
• [2020-11-10 00:07] Validation started with lhcb-reco15-patches#576
• [2020-11-11 00:22] Validation started with lhcb-reco15-patches#577
• [2020-11-12 00:09] Validation started with lhcb-reco15-patches#578
• [2020-11-17 00:11] Validation started with lhcb-reco15-patches#579
• [2020-11-18 00:09] Validation started with lhcb-reco15-patches#580
• [2020-11-19 00:09] Validation started with lhcb-reco15-patches#581
• [2020-11-26 00:13] Validation started with lhcb-reco15-patches#582
• [2020-11-27 00:18] Validation started with lhcb-reco15-patches#583

added 3 commits

• 4c679385 - Remove obsolete cmt files
• adbc359b - Remove obsolete *Sys/CMakeLists.txt and tests
• 45a42c4c - Fix many tests and remove obsolete ones

Compare with previous version

added 2 commits

• 417c4f3d - Add .gitignore
• 4ede4723 - Remove tests for compatibility with old data/tags

Compare with previous version

added 8 commits

• 0f1fee8a - Add L0 and HLT (non-split) tests for 2015 MC TCK
• 6a2c52f3 - Remove failing tests not needed for legacy branch
• 4c5abc01 - Update reference for HLT1 PrChecker
• 1b1b122f - Port generator FSR merging to 2015 stack
• 98fded3b - Cherry pick !49 (merged) to hlt2015-patches
• b50a40cd - Cherry-pick !47 (merged) to hlt2015-patches (Generator FSRs)
• 43afc7c7 - Cherry-pick !52 (merged) to hlt2015-patches
• fbbe10ed - Cherry pick and adapt parts of !120 (merged) (L0App)

Compare with previous version

added 8 commits

• b9648b13 - Add L0 and HLT (non-split) tests for 2015 MC TCK
• b4643875 - Remove failing tests not needed for legacy branch
• 4c7ff9e1 - Update reference for HLT1 PrChecker
• 46344998 - Port generator FSR merging to 2015 stack
• f2d0ab45 - Cherry pick !49 (merged) to hlt2015-patches
• 149281ce - Cherry-pick !47 (merged) to hlt2015-patches (Generator FSRs)
• db74da65 - Cherry-pick !52 (merged) to hlt2015-patches
• a512ffb0 - Cherry pick and adapt parts of !120 (merged) (L0App)

Compare with previous version

changed the description

mentioned in merge request Phys!739 (merged)

mentioned in merge request Rec!2133 (merged)

added 2 commits

• d2e66320 - Add functor cache for 2015 MC TCKs
• 0628e2dd - Update HLT reference for running with functor cache

Compare with previous version

added 1 commit

• fe63cbc8 - Update refs from lhcb-reco15-patches/576

Compare with previous version

changed the description

added 1 commit

• c693b9a0 - Add copyright and copyright check

Compare with previous version

changed the description

For the record I've observed slight differences when running locally (on lbquantaperf02, Intel(R) Xeon(R) CPU E5-2630 v4). So far the tests seem stable in the nightlies.

--- Hlt/Moore/tests/refs/sim09_hlt12.ref
+++ Hlt/Moore/tests/refs/sim09_hlt12.ref
@@ -3583,11 +3583,11 @@ InECALForHlt2_PID_CALO                   SUCCESS Number of counters : 4                                                    
 ClusterMatchForHlt2_PID_CALO             SUCCESS Number of counters : 6
  |    Counter                                      |     #     |    sum     | mean/eff^* | rms/err^*  |     min     |     max     |               
  | "#calos"                                        |      2971 |     334271 |     112.51 |     42.155 |      5.0000 |      328.00 |               
- | "#chi2"                                         |   4124268 |1.892555e+09 |     458.88 |     293.84 |  1.2252e-06 |      1000.0 |              
- | "#links"                                        |      2971 |    4124268 |     1388.2 |     1225.3 |      0.0000 |      13005. |               
+ | "#chi2"                                         |   4124267 |1.892554e+09 |     458.88 |     293.84 |  1.2252e-06 |      1000.0 |              
+ | "#links"                                        |      2971 |    4124267 |     1388.2 |     1225.3 |      0.0000 |      13005. |               
  | "#overflow"                                     |      2971 |1.51977e+07 |     5115.3 |     3864.5 |      0.0000 |      36336. |               
  | "#tracks"                                       |      2971 |     149516 |     50.325 |     21.874 |      0.0000 |      173.00 |               
- | "[ '/Event/Hlt2/TrackFitted/Long' , '/Event/Hlt2|      2971 |    4124268 |     1388.2 |     1225.3 |      0.0000 |      13005. |               
+ | "[ '/Event/Hlt2/TrackFitted/Long' , '/Event/Hlt2|      2971 |    4124267 |     1388.2 |     1225.3 |      0.0000 |      13005. |               
 SinglePhotonRecForHlt2_PID_CALO          SUCCESS Number of counters : 1
  |    Counter                                      |     #     |    sum     | mean/eff^* | rms/err^*  |     min     |     max     |               
  | "Hlt/Calo/EcalClusters=>Hlt2/PID/CALO/Calo/Photo|      2971 |     240061 |     80.801 |     29.995 |      3.0000 |      243.00 |               
@@ -3866,7 +3866,7 @@ NeutralProtoPMakerForSharedCaloProces... SUCCESS Number of counters : 88                                                     
  | "CaloShapeFr2r4 for Pi0Merged"                  |      4768 |   3476.622 |    0.72916 |    0.34829 |     -22.207 |     0.96592 |               
  | "CaloShapeKappa for Photon"                     |      2042 |   684.7077 |    0.33531 |    0.18985 |      0.0000 |     0.85916 |               
  | "CaloShapeKappa for Pi0Merged"                  |      4768 |   1597.125 |    0.33497 |    0.18315 |      0.0000 |     0.86689 |               
- | "CaloTrMatch for Photon"                        |    221868 |3.759898e+07 |     169.47 |     205.98 |      4.0007 |      999.99 |              
+ | "CaloTrMatch for Photon"                        |    221867 |3.759864e+07 |     169.46 |     205.98 |      4.0007 |      999.99 |              
  | "CaloTrMatch for PhotonFromMergedPi0"           |     15704 |   958753.3 |     61.052 |     140.68 |  5.2112e-05 |      997.95 |               
  | "CaloTrMatch for Pi0Merged"                     |      7852 |   479376.7 |     61.052 |     140.68 |  5.2112e-05 |      997.95 |               
  | "ClusterMass for Photon"                        |      3562 |   76903.46 |     21.590 |     29.836 |  8.6317e-05 |      526.90 |               
@@ -3877,7 +3877,7 @@ NeutralProtoPMakerForSharedCaloProces... SUCCESS Number of counters : 88                                                     
  | "IsNotE for Photon"                             |    235068 |   148678.4 |    0.63249 |    0.34766 |     -1.0000 |     0.99875 |               
  | "IsNotE for PhotonFromMergedPi0"                |     16010 |   6691.492 |    0.41796 |    0.28264 |    0.012247 |     0.99955 |               
  | "IsNotE for Pi0Merged"                          |      8005 |   3557.715 |    0.44444 |    0.26492 |    0.053590 |     0.99735 |               
- | "IsNotH for Photon"                             |    235068 |   81670.39 |    0.34743 |    0.40001 |     -1.0000 |     0.99900 |               
+ | "IsNotH for Photon"                             |    235068 |   81670.36 |    0.34743 |    0.40001 |     -1.0000 |     0.99900 |               
  | "IsNotH for PhotonFromMergedPi0"                |     16010 |   3650.354 |    0.22800 |    0.29086 |  2.2773e-06 |     0.99826 |               
  | "IsNotH for Pi0Merged"                          |      8005 |   2572.722 |    0.32139 |    0.34554 |  0.00024150 |     0.99838 |               
  | "IsPhoton for Photon"                           |    235068 |   234355.6 |    0.99697 |   0.042981 |    -0.23822 |      1.5324 | 

For the record, I attach the reference of the HLT test added here but ran with Moore v24r2 (as used at the pit and Sim09 productions [1]). sim09_hlt12.ref.v24r2

The differences with the references committed here on the current 2015 stack are also attached v24r2.diff. Almost all differences are at 0.1% or below at intermediate combiner stages of the Hlt2CharmHad lines. No decisions seem to be affected (on the sample of 10k inclusive B events).

[1] v24r2, the tests added here and Kernel/LHCbMath from LHCb@d6d6863e

approved this merge request

mentioned in commit 4c9d3c7f

merged