Add electrons with brem correction

Add electrons with bremsstrahlung correction to standard_particles:

• new make_long_electrons_with_brem: takes as input make_long_electrons_no_brem and make_photons and uses the new ParticleWithBremMaker introduced in Phys!820 (merged) to create electrons with brem correction applied
• modify make_detached_ee so input electrons can be passed as an option, defaulting to make_long_electrons_no_brem, which was previously hardcoded
• new make_ee_with_brem: takes as input a container of electrons and uses the new FunctionalDiElectronMaker introduced in Phys!820 (merged) to create dielectrons with brem correction applied, ensuring the same photon is not used to correct both electrons in the pair
• new make_detached_ee_with_brem: creates electrons using make_long_electrons_no_brem, filters them with detachment requirements following the selection in make_detached_ee and created dielectrons with brem correction using the above make_ee_with_brem

Add also Hlt2Conf.test_hlt2_bremsstrahlung to test the new standard particles. Three B2JpsiK_ee lines are run using make_detached_ee, make_detached_ee with make_long_electrons_with_brem, and make_detached_ee_with_brem, respectively. Currently only check for no errors and at least 1 selected candidate.

Needs Phys!820 (merged) and lhcb-datapkg/PRConfig!175 (merged)

Closes #214 (closed)

I've checked Hlt2Conf.test_hlt2_standard_particles runs fine with the addition of make_long_electrons_with_brem, are there more tests I should run when adding new standard particles? Next step would be to use this in an Hlt2 line, but I'd leave that to line authors so they can properly test the effect

changed the description

added enhancement hlt2 labels

mentioned in merge request !707 (merged)

added 203 commits

• af038ea6...4af0d224 - 199 commits from branch master
• dbf993da - add electrons with brem
• 6b2ea55d - configure BremAdder
• c79e2867 - add diElectrons with brem
• 46f572dd - add test line for brem

Compare with previous version

changed the description

added 1 commit

• 87e8b8ee - Jpsi ID, no diElectronMaker prefilter

Compare with previous version

mentioned in merge request !774 (merged)

added 68 commits

• 87e8b8ee...8d05fdb0 - 63 commits from branch master
• 31d4fdf7 - add electrons with brem
• 62378b24 - configure BremAdder
• 4e6bad5f - add diElectrons with brem
• 06a96a00 - add test line for brem
• c478556b - Jpsi ID, no diElectronMaker prefilter

Compare with previous version

added 1 commit

• f12fb558 - clean up and format

Compare with previous version

changed the description

The baseline functionality is working! I've run on 10k BToJpsiK, JpsiToEE, events to test both the ParticleWithBremMaker and the FunctionalDiElectronMaker and the Jpsi mass resolution gets much improved when adding brem, so the algorithms seem to work as expected:

(the resolution without brem looks terrible and with brem it seems still worse than in Run 1/2 but investigating such effects is out of the scope of this MR)

added 1 commit

• 9c2f338b - missing kwargs

Compare with previous version

added 1 commit

• 2da2fd4a - detached_ee_with_brem CloneFilteredParticles

Compare with previous version

resolved all threads

changed the description

added 1 commit

• cbcd4269 - adapt property names

Compare with previous version

mentioned in merge request Phys!820 (merged)

added 1 commit

• 41d5b479 - use FunctionalBremAdder

Compare with previous version