Skip to content
Snippets Groups Projects

Configurable Allen sequence

Merged Roel Aaij requested to merge allen_multiple_sequences into master

This MR takes care of setting the Allen sequence (and the associated JSON file) executed by RunAllen as part of the configuration. This allows tests as part of the stack build with different Allen sequences.

depends on Allen!552 (merged)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Shall I review after you've address @dovombru's comments?

  • Author Maintainer

    Yeah, that makes sense, I'll ping you when I've implemented them

  • Roel Aaij added 1 commit

    added 1 commit

    • bfcfe097 - Remove spurious arguments and update options

    Compare with previous version

  • Roel Aaij resolved all threads

    resolved all threads

  • Author Maintainer

    @apearce this is ready for review now.

  • Alex Pearce
  • Alex Pearce
  • Not much controversy here, just a few minor comments from me. Thanks!

  • Alex Pearce assigned to @raaij and unassigned @dovombru

    assigned to @raaij and unassigned @dovombru

  • Roel Aaij added 2 commits

    added 2 commits

    • 71dcce6d - Really remove leftover arguments in docstring
    • 0ac6f735 - Add docstring

    Compare with previous version

  • mentioned in issue #272 (closed)

  • mentioned in issue #273 (closed)

  • Ao Xu mentioned in issue #278 (closed)

    mentioned in issue #278 (closed)

  • Developer

    Hi @raaij, please resolve all threads and assign to me when this is ready for test.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading