Draft: Moore muon moni

Added Moore/Hlt/RecoConf/python/RecoConf/muonPID_data_monitoring.py to configure the new class Rec/Muon/MuonPIDChecker/src/MuonMonitorAlg.cpp The class MuonMonitorAlg.cpp fills few histograms to monitor the MuonID after Hlt2 reconstruction.

Modified Moore/Hlt/RecoConf/python/RecoConf/standalone.py to call the new MuonID monitoring.

Thanks @desimone. Is this MR ready to go from your side? If so, could you please:

1. Change the title to something more descriptive and expand the description to explain what's being added and why.
2. Remove the .vscode directory from the MR.

If it's not ready yet you can mark it as 'draft'.

changed the description

Thanks @apearce. The MR is ready.

Could you please remove the .vscode directory from the MR?

mentioned in merge request Rec!2476 (closed)

The comment says we cannot run this by default, but here you are running the algorithm. Is the algorithm now thread safe? Is it safe to always run it?

Same comment here as above.

@rvazquez and @mfontana do you know who is taking care of this problem ? ( MuonChi2MatchTool is not thread-safe )

we were discussing this with @rvazquez recently. The configuration still calls the old MuonIDAlgLite, see hlt2_muonid.py, which is indeed not thread-safe. However a new thread-safe algorithm exists, we need to revive !684 (closed) (or a new MR doing something similar) to get it in the reco sequence. @rvazquez could you check if !684 (closed) can still be used (it will surely need rebasing) or just close it and start a new MR from scratch?

Thanks @cmarinbe for these infos !

MuonChi2MatchTool will not be used. The more I look into it, the clearer is to me that we need a single code for the MuonID (MuonIDHlt1Alg.cpp is enough) that already computes the chi2Corr. This code is templated so can take as input the Hlt1 or Hlt2 tracks.

I am very busy this week with the moving, but next week I will take a look at all this and clean up the MR that were overwriten by something else.

I would say that make_muon_id_hlt2 could use also MuonIDHlt1Alg.

Thanks @rvazquez, that sounds good to me.

Shall we set this MR as a draft until that work is ready? My understanding is that we need a thread-safe muon ID in the configuration before this MR can proceed.

If @desimone agrees, I would say so.

@rvazquez and @apearce, this looks a good solution for me.

assigned to @rvazquez

marked this merge request as draft

Hi @rvazquez and @apearce ! Which is the status of the clean up that @rvazquez was talking about ? Is this MR still a draft ? Thanks a lot :) !!

Hi @apearce and @rvazquez. Can you please update me about the status of this merge request ? Thanks a lot ! It looks that there are merge conflicts .. I did not touch/change nothing ..

closed

reopened

mentioned in merge request !684 (closed)

added RTA label

mentioned in merge request !1600 (merged)

Superseeded by !1600 (merged)

closed