Skip to content
Snippets Groups Projects

HLT efficiency checker for Allen

Based on !1 (merged) .

Depends on Allen!281 (merged), Moore!378 (merged), Rec!1897 (merged), lhcb-datapkg/PRConfig!111 (merged), Allen!421 (merged)

The MR is in the process of being updated to the reworked framework of the HltEfficency checker.

  • Provide functions to call Allen in Moore in config.py
  • Provide scripts for manual calling of efficiency & rate checkers
  • Fix trigger rates of zero: DecReports not read correctly?
  • Include options to call Allen in Moore via the wizard
  • Make Allen the default HLT1 choice (incl. updating documentation - Moore!580 (merged))
Edited by Ross John Hunter

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ross John Hunter added 2 commits

    added 2 commits

    • 3b883eba - Fix xmax bug
    • 57b8b4cc - Merge branch 'dovombru_rjhunter-HltEfficiencyChecker_for_Allen' of...

    Compare with previous version

  • Rosen Matev mentioned in merge request !1 (merged)

    mentioned in merge request !1 (merged)

  • Ross John Hunter added 38 commits

    added 38 commits

    • 57b8b4cc...d095ff4a - 27 commits from branch master
    • 620bc0cc - start calling the efficiency script for Allen
    • e66d7aab - Align running commands with recent changes
    • 349dca64 - call Allen from efficiency script
    • 6512bfa4 - cleanup
    • 2f0cde4b - prepend Hlt1 to trigger line names
    • 1fb42680 - update to calling MCTupleToolKinematic
    • c22ab432 - add ZMuMu and BsPhiPhi v4 samples to dictionary
    • a5cb8588 - add remaining v4 samples to dictionaries
    • 0fd6b4ab - fixes to Loki particle names and proper name for v4 testfile DB samples
    • 315f2b73 - Get a better name if using MinBias
    • e853dabf - Merge branch 'dovombru_rjhunter-HltEfficiencyChecker_for_Allen' of...

    Compare with previous version

  • Okay I think I managed to pick all the right changes in that rebase. I might have temporarily broke the bits which call the subscripts, but I need to fix this anyway so that we select hlt1_allen_maketuple.py or hlt1_runtrigger_maketuple.py. I should probably rename the latter as well.

  • added 1 commit

    Compare with previous version

  • What are people's thoughts on amalgamating hlt1_runtrigger_maketuple.py and hlt1_allen_maketuple.py into one script? There is quite a bit of duplicated code between the two when setting up the control flow, which means that if we decide to change something there we will have to remember to do it in both scripts to keep the comparison fair.

    We could set an environment variable in HltEfficiencyChecker.py based upon the positional argument it will have to select between the two, and then you just check this environment with a lot of if statements for Moore and Allen specific control flow set ups.

    On the other hand, we're only taking about probably 50 lines of code that we'd have to stay on top of, and these lines are probably not too likely to change significantly.

  • Ross John Hunter added 3 commits

    added 3 commits

    • a011140d - Added positional arg and check to choose between Allen and Moore
    • a9003726 - remove hard-coded Allen path
    • d829f70b - Insert a warning to remember to fix the --dump option

    Compare with previous version

  • added 1 commit

    • eab6f9cb - Make Moore script run over both FTv4 and FTv6 decoding

    Compare with previous version

  • Ross John Hunter mentioned in merge request !6 (merged)

    mentioned in merge request !6 (merged)

  • Ross John Hunter added 2 commits

    added 2 commits

    • 2a62e386 - Propagate the trigger flag through to plot titles and names
    • 863dc250 - Make --trigger required

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Ross John Hunter added 1 deleted label

    added 1 deleted label

  • Ross John Hunter mentioned in merge request !5 (merged)

    mentioned in merge request !5 (merged)

  • Dorothea Vom Bruch resolved all threads

    resolved all threads

  • Ross John Hunter added 3 commits

    added 3 commits

    • de44365d - Update doc string
    • c3f8bf6d - Made the example test run Moore, and added 2nd test to do the same for Allen
    • 56e04312 - Renamed this test

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading