HLT efficiency checker for Allen
Based on !1 (merged) .
Depends on Allen!281 (merged), Moore!378 (merged), Rec!1897 (merged), lhcb-datapkg/PRConfig!111 (merged), Allen!421 (merged)
The MR is in the process of being updated to the reworked framework of the HltEfficency checker.
-
Provide functions to call Allen in Moore in config.py -
Provide scripts for manual calling of efficiency & rate checkers -
Fix trigger rates of zero: DecReports not read correctly? -
Include options to call Allen in Moore via the wizard -
Make Allen the default HLT1 choice (incl. updating documentation - Moore!580 (merged))
Merge request reports
Activity
- Resolved by Dorothea Vom Bruch
- Resolved by Ross John Hunter
cc @rmatev
mentioned in merge request !1 (merged)
- Resolved by Ross John Hunter
@rjhunter @dovombru can someone rebase now that !1 (merged) is merged?
added 38 commits
-
57b8b4cc...d095ff4a - 27 commits from branch
master
- 620bc0cc - start calling the efficiency script for Allen
- e66d7aab - Align running commands with recent changes
- 349dca64 - call Allen from efficiency script
- 6512bfa4 - cleanup
- 2f0cde4b - prepend Hlt1 to trigger line names
- 1fb42680 - update to calling MCTupleToolKinematic
- c22ab432 - add ZMuMu and BsPhiPhi v4 samples to dictionary
- a5cb8588 - add remaining v4 samples to dictionaries
- 0fd6b4ab - fixes to Loki particle names and proper name for v4 testfile DB samples
- 315f2b73 - Get a better name if using MinBias
- e853dabf - Merge branch 'dovombru_rjhunter-HltEfficiencyChecker_for_Allen' of...
Toggle commit list-
57b8b4cc...d095ff4a - 27 commits from branch
What are people's thoughts on amalgamating
hlt1_runtrigger_maketuple.py
andhlt1_allen_maketuple.py
into one script? There is quite a bit of duplicated code between the two when setting up the control flow, which means that if we decide to change something there we will have to remember to do it in both scripts to keep the comparison fair.We could set an environment variable in
HltEfficiencyChecker.py
based upon the positional argument it will have to select between the two, and then you just check this environment with a lot ofif
statements forMoore
andAllen
specific control flow set ups.On the other hand, we're only taking about probably 50 lines of code that we'd have to stay on top of, and these lines are probably not too likely to change significantly.
added 1 commit
- eab6f9cb - Make Moore script run over both FTv4 and FTv6 decoding
mentioned in merge request !6 (merged)
- Resolved by Ross John Hunter
- [2020-02-23 00:09] Validation started with lhcb-test-efficiency#13
- [2020-02-24 00:09] Validation started with lhcb-test-efficiency#14
- [2020-02-29 00:09] Validation started with lhcb-test-efficiency#19
Edited by Software for LHCb
mentioned in merge request !5 (merged)