Set AllEvent cut string to "always true"
When combining AllEvents
with other denoms an error was occurring because AllEvents
was an empty string. Now it's set to "1" to work in combination with other denoms.
Merge request reports
Activity
added bug fix label
assigned to @rjhunter
assigned to @thboettc
added RTA label
requested review from @rjhunter
unassigned @rjhunter
- Resolved by Andre Gunther
Hi @gunther, nice fix! I take it you have tested that this works out OK on your efficiencies? I assume that
ROOT
does the right thing and converts1
->true
, but I've never done this explicitly. If ever I wanted an "always pass" cut I do "(1>0)". Can you put my mind at ease and tell me it works please?
- Resolved by Andre Gunther
/ci-test
added ci-test-triggered label
- [2022-04-30 18:32] Validation started with lhcb-master-mr#4337
assigned to @rmatev
mentioned in issue Moore#426 (closed)
@mfontana this is ready for final testing, no hurdles expected
- Resolved by Andre Gunther
/ci-test
- [2022-05-11 10:40] Validation started with lhcb-master-mr#4385
- [2022-05-31 22:17] Validation started with lhcb-master-mr#4586
Edited by Software for LHCbmentioned in issue Moore#432 (closed)
assigned to @rmatev
Tests look fine, I'm handing this over to you @rmatev
assigned to @sponce
added 8 commits
-
1b162440...cb29d128 - 7 commits from branch
master
- de2c4bf2 - fix AllEvent denom
-
1b162440...cb29d128 - 7 commits from branch
mentioned in issue Moore#436 (closed)
- Resolved by Sebastien Ponce
@sponce can we merge this?
mentioned in commit 36b76cab
mentioned in issue Moore#444 (closed)