Phys merge requestshttps://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests2023-03-24T16:26:30+01:00https://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/1024Draft: Allow Filter and ThOrCombiner to process neutrals2023-03-24T16:26:30+01:00Miguel Ramos PernasDraft: Allow Filter and ThOrCombiner to process neutralsAdapt the ThOr combiner in such a way that it can process `NeutralBasics` modifying the vertex fitter accordingly. Define also an algorithm to make `NeutralBasics` out of the ECAL reconstruction container and a filter using `Pr::Filter`....Adapt the ThOr combiner in such a way that it can process `NeutralBasics` modifying the vertex fitter accordingly. Define also an algorithm to make `NeutralBasics` out of the ECAL reconstruction container and a filter using `Pr::Filter`.
Depends on lhcb/LHCb!3307, lhcb/Rec!2639; used on lhcb/Moore!1200https://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/964Draft: Added support for flavourTag persistence2023-03-24T16:24:09+01:00Eva Brottmann HansenDraft: Added support for flavourTag persistenceThe changes are required to enable persistence of LHCb::FlavourTag objects in Moore. A MR has also been made for the corresponding Moore branch.The changes are required to enable persistence of LHCb::FlavourTag objects in Moore. A MR has also been made for the corresponding Moore branch.Eva Brottmann HansenEva Brottmann Hansenhttps://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/936WIP: SOA converters from/to Composites and v1 Particle2022-10-08T11:25:34+02:00Sevda EsenWIP: SOA converters from/to Composites and v1 ParticleFirst task towards SOA persistency. Adding converters for v1->SOA and SOA->v1 particles, as required either by HLT2 for writing, or DPA(+offline) for reading.
@apearce @jonrobFirst task towards SOA persistency. Adding converters for v1->SOA and SOA->v1 particles, as required either by HLT2 for writing, or DPA(+offline) for reading.
@apearce @jonrobSevda EsenSevda Esenhttps://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/998Draft: First implementation of CatBoost in the Topo2022-03-06T20:33:38+01:00Nicole SchulteDraft: First implementation of CatBoost in the TopoFirst Draft of the topological-b classification using Catboost.
For that we used the inital TMVA implementation and adjusted it to Catboost.
Done:
* First Twobody implementation
* First Threebody implementation
* Build Json Reader
* ...First Draft of the topological-b classification using Catboost.
For that we used the inital TMVA implementation and adjusted it to Catboost.
Done:
* First Twobody implementation
* First Threebody implementation
* Build Json Reader
* check efficiency and rates
* validate 3body
To Do:
* implement with ThOr
Moore!1050
CC: @mvesteri @poluekt @nnolte @msaur @gciezareNicole SchulteNicole Schultehttps://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/1011Draft: one example flavourtagger to test persistency2022-01-18T15:26:39+01:00Claire ProuveDraft: one example flavourtagger to test persistencyThe functional flavourtagging is not finished yet, but we need to set up a test for the persistency of the `FlavourTags` objects.
Also, in this MR the `ParticleDescendants` tool is moved to Phys, therefore depends on https://gitlab.cer...The functional flavourtagging is not finished yet, but we need to set up a test for the persistency of the `FlavourTags` objects.
Also, in this MR the `ParticleDescendants` tool is moved to Phys, therefore depends on https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/836.https://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/1036Draft: Add tool for storing particle taggers information with FunTuple2022-01-14T12:01:01+01:00Davide FazziniDraft: Add tool for storing particle taggers information with FunTupleAdding a new tool that creates a map relating the B candidate to all the tagging particles available in a set of TES locations defined by the user. \
Needs https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2672Adding a new tool that creates a map relating the B candidate to all the tagging particles available in a set of TES locations defined by the user. \
Needs https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2672Davide FazziniDavide Fazzinihttps://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/1035Draft: catch a nullptr in NeutralMakers2022-01-13T16:30:46+01:00Valeriia LukashenkoDraft: catch a nullptr in NeutralMakersCatching the nullptr from the calo hypotheses vector.
To Do:
- [ ] Add an appropriate Error message
@sstahlCatching the nullptr from the calo hypotheses vector.
To Do:
- [ ] Add an appropriate Error message
@sstahlhttps://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/1029MC truth association algorithm (MCTruthAlg) and Background Category2022-01-12T18:47:57+01:00Abhijit MathadMC truth association algorithm (MCTruthAlg) and Background CategoryAlgorithm outputs two type of relations table:
- First between reconstructed and truth objects (Adaptation of `TupleToolMCTruth`) using the association tools.
- Second between composite and background category (i.e. `TupleToolMCBackgroun...Algorithm outputs two type of relations table:
- First between reconstructed and truth objects (Adaptation of `TupleToolMCTruth`) using the association tools.
- Second between composite and background category (i.e. `TupleToolMCBackgroundInfo`).
Related to (but not dependent on): issue (https://gitlab.cern.ch/lhcb-dpa/project/-/issues/145), MR (https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2652) and MR (https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/846).
cc: @mferrill and @powenRosen MatevAbhijit MathadPatrick KoppenburgRosen Matevhttps://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/1034Dropped unused code around HitExpectation2022-01-12T16:25:21+01:00Sebastien PonceDropped unused code around HitExpectationPart of the set of MRs LHCb!3369, Lbcom!594, Rec!2670, Phys!1034, Boole!375Part of the set of MRs LHCb!3369, Lbcom!594, Rec!2670, Phys!1034, Boole!375https://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/1026Draft: Add vertex constraints to DecayTreeFitterAlg2022-01-12T15:57:44+01:00Patrick KoppenburgDraft: Add vertex constraints to DecayTreeFitterAlg1. Pass mass constraint by string. Addresses https://gitlab.cern.ch/lhcb-dpa/project/-/issues/175 . This is now https://gitlab.cern.ch/lhcb/Phys/-/merge_requests/1030.
2. Constrain to PV : https://gitlab.cern.ch/lhcb-dpa/project/-/issues...1. Pass mass constraint by string. Addresses https://gitlab.cern.ch/lhcb-dpa/project/-/issues/175 . This is now https://gitlab.cern.ch/lhcb/Phys/-/merge_requests/1030.
2. Constrain to PV : https://gitlab.cern.ch/lhcb-dpa/project/-/issues/172
Needs a DaVinci test.Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/919Draft: Remove MVADictTools2022-01-12T11:40:32+01:00Patrick KoppenburgDraft: Remove MVADictToolsFollowing the discussion at https://gitlab.cern.ch/lhcb-dpa/project/-/issues/95#note_4384968, trying to remove MVADictTools to see what happens.Following the discussion at https://gitlab.cern.ch/lhcb-dpa/project/-/issues/95#note_4384968, trying to remove MVADictTools to see what happens.Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/1019Draft: Make Muon code ready for DD4hep integration2021-12-09T10:48:04+01:00Sebastien PonceDraft: Make Muon code ready for DD4hep integrationhttps://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/929Draft: Add missing links to libraries (@clemenci)2021-11-23T10:36:38+01:00Marco CattaneoDraft: Add missing links to libraries (@clemenci)Cherry pick of !927 on masterCherry pick of !927 on masterhttps://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/815WIP: Use JetVertexAlg algorithm in Moore2021-09-16T09:19:34+02:00Davide ZulianiWIP: Use JetVertexAlg algorithm in MooreFirst attempt to get the JetVertexAlg algorithm to work in the Moore framework.
Some changes have been done in `JetVertexAlg.cpp` and `ParticleLocation.h` in order to get the right paths for input and output particles.
The algorithm is c...First attempt to get the JetVertexAlg algorithm to work in the Moore framework.
Some changes have been done in `JetVertexAlg.cpp` and `ParticleLocation.h` in order to get the right paths for input and output particles.
The algorithm is called by a wrapper in order to make it work in the Hlt2 line.Davide ZulianiDavide Zulianihttps://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/957Adding new velo track LoKi-Functors for the restripping (2016-patches)2021-09-13T16:39:26+02:00Hendrik JageAdding new velo track LoKi-Functors for the restripping (2016-patches)Adding new LoKi-Functors allowing to access velo cluster information in the upcoming 2016 restripping.
These changes are mostly identical to those already merged to `2017-patches` (MR [!908 (merged)](https://gitlab.cern.ch/lhcb/Phys/-/m...Adding new LoKi-Functors allowing to access velo cluster information in the upcoming 2016 restripping.
These changes are mostly identical to those already merged to `2017-patches` (MR [!908 (merged)](https://gitlab.cern.ch/lhcb/Phys/-/merge_requests/908)). The only difference is that `LoKi::Extract::Particle2Track`, which is used to access the `track`, seems to work differently in `2016-patches`.
The corresponding MR for `2018-patches` is MR [!956 ](https://gitlab.cern.ch/lhcb/Phys/-/merge_requests/956).
The following functors are added:
* TRVELOCLUSTERS: number of velo clusters
* TRVELOCLUSTERADC: adc values of each velo cluster
* TRVELOCLUSTERDEDX: dedx information of each velo cluster
* TRVELOCLUSTERSTRIPS: number of strips making up each velo cluster
* TRVELOCLUSTERDEDXMEDIAN: median of the dedx velo cluster information along the track
* TRVELOCLUSTEROVERFLOWS: number of overflowing velo strips along the track
* TRVELOCLUSTEROVERFLOWFRAC: fraction of overflowing velo strips per cluster along the trackhttps://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/973Draft: Long lived charged hyperons as protoparticles2021-09-04T18:32:43+02:00Marian Stahlmarian.stahl@cern.chDraft: Long lived charged hyperons as protoparticlesAdds charged hyperons to `Phys/ParticleMaker/src/FunctionalParticleMaker.cpp`Adds charged hyperons to `Phys/ParticleMaker/src/FunctionalParticleMaker.cpp`https://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/937Update reference files from lhcb-head-2 2442021-08-19T20:18:37+02:00Ao XuUpdate reference files from lhcb-head-2 244To be tested with LHCb!3056.To be tested with LHCb!3056.Ao XuAo Xuhttps://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/935Draft: Add LoKi adaptor ThOr functor2021-06-30T09:21:07+02:00Alex PearceDraft: Add LoKi adaptor ThOr functorTowards Rec#169. Currently requires https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2429 but probably shouldn't; the Python code there should be moved here or the LoKi dependency moved to Rec.
To be addressed, off the top of my head:
...Towards Rec#169. Currently requires https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2429 but probably shouldn't; the Python code there should be moved here or the LoKi dependency moved to Rec.
To be addressed, off the top of my head:
- Tests. (I ran a local test and got identical results with `F.LOKI("PT")` versus `F.PT`, but should be formalised).
- Compatibility with the `DV` class of LoKi functors. These expect the owning algorithm to be derived from `DVCommonBase` so that they can call functions to e.g. get PVs and PV relations, but we expect to drop `DVCommonBase` support in the future. The algorithms we already have which operate on `LHCb::Particle` using ThOr functors do not derive from `DVCommonBase`.
- Adapters for combinations. The `A` series of LoKi functors, like `AM`, have a different signature. The adapter here is hard-coded for the signature of `LHCb::Particle` input (i.e. not combinations).
- Support 'preambulos', i.e. lists of strings of Python code to be executed before the functor code is evaluated.
- TBD if we actually want this.https://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/925SOA Track Fix2021-04-26T17:24:37+02:00Alexander Leon GilmanSOA Track FixFixes conflicts with master and SOA Track MR. Related to !882. Run concurrent to Rec!2408 and LHCb!3011.Fixes conflicts with master and SOA Track MR. Related to !882. Run concurrent to Rec!2408 and LHCb!3011.Juan LeiteAlexander Leon GilmanJuan Leitehttps://gitlab.cern.ch:8443/lhcb/Phys/-/merge_requests/912Draft: Resolve LHCBPS-1886 "Vanya jira "2021-04-01T08:58:42+02:00Vanya BelyaevDraft: Resolve LHCBPS-1886 "Vanya jira "Closes LHCBPS-1886Closes LHCBPS-1886