Skip to content
Snippets Groups Projects

More microDST cloners

Merged Alex Pearce requested to merge apearce-dynamic-cloning into master

This adds three new copy algorithms to the MicroDST package, for LBHLT-135:

  1. CopyCaloClusters: for copying containers of LHCb::CaloCluster objects;
  2. CopyLinePersistenceLocations: for cloning any KeyedContainer, and its contents, if the location is defined by the ILinePersistenceSvc (see LHCb!606 (merged)); and
  3. CopyParticle2PVRelationsFromLinePersistenceLocations: for cloning any LHCb::Particle to LHCb::RecVertex relations tables, if the location is defined by the ILinePersistenceSvc.

Marked as WIP for now as I'd like to add some more documentation.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
54 54 }
55 55 }
56 56
57 Gaudi::Utils::setProperty(this, "InputLocations", locationsToCopy);
57 for (const auto& location: locationsToCopy) {
58 this->copyTableFromLocation(location);
59 }
58 60
  • Alex Pearce added 1 commit

    added 1 commit

    • 8f028a9b - Always continue, regardless of msgLevel.

    Compare with previous version

  • Roel Aaij
  • Alex Pearce added 1 commit

    added 1 commit

    • c18bf434 - Use the appropriate algorithm declaration macro.

    Compare with previous version

  • Alex Pearce resolved all discussions

    resolved all discussions

  • Is there an urge to get this into the stack presently in preparation? If yes then I will remove the "WIP" tag to get the code tested in the nightlies … What's your take?

  • Yes, this is definitely needed. Removing the wip

  • Rosen Matev unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Katya Govorkova mentioned in merge request Hlt!284 (merged)

    mentioned in merge request Hlt!284 (merged)

  • I would just like to add some docs, add a couple more object types to the dynamic cloner, and fix a couple of bugs. I'll do this this morning and let you know. Thanks for reminding me @erodrigu!

  • Alex Pearce added 3 commits

    added 3 commits

    • 899c7df6 - Support more object types.
    • bc2d6cc3 - Don't print a warning, as the behaviour is expected.
    • 94b45681 - Document LinePersistence cloner algorithms.

    Compare with previous version

  • Alex Pearce added 2 commits

    added 2 commits

    Compare with previous version

  • Alex Pearce added 1 commit

    added 1 commit

    • 1463c475 - Cloners use VertexBase rather than RecVertex.

    Compare with previous version

  • This should ready. Would you mind having a quick look @rmatev?

  • Alex Pearce added 1 commit

    added 1 commit

    • 5019f056 - Allow different types for KeyedContainer contents and cloner source objects.

    Compare with previous version

  • @rmatev, you're OK with all this? I assume yes so will accept the MR later today ...

  • @erodrigu could you please hold on until the end of the day?

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading