Skip to content

[WIP] Fix RebuildSelection for non-trivial structures in Common/Standard particles

Eduardo Rodrigues requested to merge erodrigu-cherrypick-2017 into 2017-patches

(cherry picked from commit 00ea600e) See !532 (merged).

From: Vanya Belyaev Ivan.Belyaev@cern.ch

Hi Giovannni,

Indeed there is incorrectness in RebuildSelection for the treatment of non-standard modules.

I've put MR in Phys: !532 (merged)

With this patch and attached module, it seems to work properly

cheers, Vanya

From: Carlos Vazquez Sierra carlos.vazquez@cern.ch

Hi Giovanni, Vanya,

this happens because the StdLooseResolvedPi0 algorithm is called 'fltr', not 'algorithm',

$ from CommonParticles.StdLooseResolvedPi0 import StdLooseResolvedPi0 as neutralPions
$ neutralPions.algorithm
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: 'module' object has no attribute 'algorithm'
$ neutralPions.fltr
FilterDesktop('StdLooseResolvedPi0')

see:

https://gitlab.cern.ch/lhcb/Phys/blob/v25r7/Phys/CommonParticles/python/CommonParticles/StdLooseResolvedPi0.py#L49

so RebuildSelection crashes when trying to get that property from StdLooseResolvedPi0:

https://gitlab.cern.ch/lhcb/Phys/blob/v25r7/PhysSel/PhysSelPython/python/PhysSelPython/Wrappers.py#L2148

Cheers

Edited by Carlos Vazquez Sierra

Merge request reports