Skip to content
Snippets Groups Projects

Give different default names to identically-typed ToolHandles

Merged Alex Pearce requested to merge apearce-cloner-toolhandle-names into master
All threads resolved!

See gaudi/Gaudi#116 for discussion, but in essence: having multiple ToolHandle properties on an algorithm which have the same type can cause tool configuration to have no effect (i.e. to not be seen by the JobOptionsSvc). This was seen the occur when configuring the CopyLinePersistenceLocations algorithm in PyConf (but can be reproduced with plain Configurables).

The workaround is to explicitly give unique default names to each ToolHandle property. I don't know whether the behaviour is expected or is a bug in Gaudi, but either way the fix works and isn't too invasive, so I'm happy taking it for now.

This will go with Moore!324 (merged)

Edited by Peilian Li

Merge request reports

Pipeline #1430303 passed

Pipeline passed for 014a34f0 on apearce-cloner-toolhandle-names

Merged by Rosen MatevRosen Matev 5 years ago (Feb 28, 2020 4:27pm UTC)

Merge details

  • Changes merged into master with cd194e5f (commits were squashed).
  • Deleted the source branch.

Pipeline #1450792 passed

Pipeline passed for cd194e5f on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading