Give different default names to identically-typed ToolHandles

See gaudi/Gaudi#116 for discussion, but in essence: having multiple ToolHandle properties on an algorithm which have the same type can cause tool configuration to have no effect (i.e. to not be seen by the JobOptionsSvc). This was seen the occur when configuring the CopyLinePersistenceLocations algorithm in PyConf (but can be reproduced with plain Configurables).

The workaround is to explicitly give unique default names to each ToolHandle property. I don't know whether the behaviour is expected or is a bug in Gaudi, but either way the fix works and isn't too invasive, so I'm happy taking it for now.

This will go with Moore!324 (merged)

MicroDST/MicroDSTAlgorithm/src/CopyLinePersistenceLocations.h

@@ -112,10 +112,10 @@ private:
   Gaudi::Property<std::string> m_linePersistenceSvcName{this, "ILinePersistenceSvc", "TCKLinePersistenceSvc"};
 
   /// Implementation of ICloneCaloCluster used to clone LHCb::CaloCluster objects.
-  ToolHandle<ICloneCaloCluster> m_caloClusterCloner{this, "ICloneCaloCluster", "CaloClusterCloner"};
+  ToolHandle<ICloneCaloCluster> m_caloClusterCloner{this, "ICloneCaloCluster", "CaloClusterCloner/CaloClusterCloner"};
 
   /// Implementation of ICloneCaloHypo used to clone LHCb::CaloHypo objects.
-  ToolHandle<ICloneCaloHypo> m_caloHypoCloner{this, "ICloneCaloHypo", "CaloHypoCloner"};
+  ToolHandle<ICloneCaloHypo> m_caloHypoCloner{this, "ICloneCaloHypo", "CaloHypoCloner/CaloHypoCloner"};
 
   /// Implementation of ICloneParticle used to clone LHCb::Particle objects.
   ToolHandle<ICloneParticle> m_particleCloner{this, "ICloneParticle", "ParticleCloner"};
@@ -124,17 +124,20 @@ private:
   ToolHandle<ICloneProtoParticle> m_protoParticleCloner{this, "ICloneProtoParticle", "ProtoParticleCloner"};
 
   /// Implementation of ICloneVertexBase used to clone LHCb::VertexBase objects
-  ToolHandle<ICloneVertexBase> m_vertexCloner{this, "ICloneVertexBase", "VertexBaseFromRecVertexClonerNoTracks"};
+  ToolHandle<ICloneVertexBase> m_vertexCloner{this, "ICloneVertexBase",
+                                              "VertexBaseFromRecVertexClonerNoTracks/RecVertexCloner"};
 
   /// Implementation of ICloneCaloClusterCloner used to clone LHCb::CaloCluster objects for Turbo++ lines
-  ToolHandle<ICloneCaloCluster> m_turboPPCaloClusterCloner{this, "TurboPPICloneCaloCluster", "CaloClusterCloner"};
+  ToolHandle<ICloneCaloCluster> m_turboPPCaloClusterCloner{this, "TurboPPICloneCaloCluster",
+                                                           "CaloClusterCloner/TurboPPCaloClusterCloner"};
 
   /// Implementation of ICloneCaloHypoCloner used to clone LHCb::CaloHypo objects for Turbo++ lines
-  ToolHandle<ICloneCaloHypo> m_turboPPCaloHypoCloner{this, "TurboPPICloneCaloHypo", "CaloHypoCloner"};
+  ToolHandle<ICloneCaloHypo> m_turboPPCaloHypoCloner{this, "TurboPPICloneCaloHypo",
+                                                     "CaloHypoCloner/TurboPPCaloHypoCloner"};
 
   /// Implementation of ICloneVertexBase used to clone LHCb::VertexBase objects for Turbo++ lines
   ToolHandle<ICloneVertexBase> m_turboPPVertexCloner{this, "TurboPPICloneVertexBase",
-                                                     "VertexBaseFromRecVertexClonerWithTracks"};
+                                                     "VertexBaseFromRecVertexClonerWithTracks/TurboPPRecVertexCloner"};
 
   /// List of HLT2 lines whose outputs are to be copied.
   Gaudi::Property<std::vector<std::string>> m_linesToCopy{this, "LinesToCopy", {}};