Skip to content
Snippets Groups Projects

Remove any mention of L0 in TisTos

Merged Patrick Koppenburg requested to merge pkoppenb-20200629-RemoveL0FromTisTos into master

Removed any mention of L0 in TisTos. In particular:

  • Removal of all src/L0*.{cpp,h}
  • Removal of all code only run if L0 is present
  • The size of enum TriggerStages { defaultTriggerStage = 0, HLT1 = defaultTriggerStage, HLT2, NTriggerStages } has changed

Related MR: Analysis!643 (merged) (TupleToolTISTOS) DaVinci!408 (merged) (DaVinci configuration)

With these changes I am able to run TupleToolTISTOS on upgrade simulation (./run gaudirun.py -v Phys/DaVinci/options/DaVinci-Example.py Phys/DaVinci/options/DaVinciTestData.py) and the results seem meaningful.

Questions:

  • Is Phys/TisTosTobbing/src/Hlt2TriggerTisTos.cpp needed? It addresses a run 2 bug/feature described in https://its.cern.ch/jira/browse/LHCBPS-1746 : @olupton ?
  • Are there any side effects I have missed?
  • Are there regions of the code that cannot be accessed any longer and should also be removed?
  • Anything else that should be removed? -> Need approval of @tskwarni
Edited by Patrick Koppenburg

Merge request reports

Pipeline #1765287 passed

Pipeline passed for 4399467a on pkoppenb-20200629-RemoveL0FromTisTos

Merged by Christopher Rob JonesChristopher Rob Jones 4 years ago (Jul 3, 2020 10:49am UTC)

Loading

Pipeline #1768126 passed

Pipeline passed for dca59ea3 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tomasz Skwarnicki approved this merge request

    approved this merge request

  • Edited by Software for LHCb
  • @acasaisv not quite yet. I'd like to make the changes suggested by @tskwarni above.

  • added 1 commit

    • f77be636 - Implement suggestions by Tomasz

    Compare with previous version

  • Now included Tomasz' suggestions.

  • Patrick Koppenburg unmarked as a Work In Progress

    unmarked as a Work In Progress

  • added cleanup label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading