Remove instantiation of the LoKi service since now in the DaVinci configurable

See new DaVinci configurable work at DaVinci!432 (merged).

FYI @dfazzini, @mamartin and @pkoppenb.

added Configuration label

assigned to @pkoppenb

This is just the start of work related to https://gitlab.cern.ch/lhcb-dpa/project/-/issues/48 for what concerns the derived configurables in Phys and Analysis. To be clear, I have a reasonably strong feeling that we will be able to get rid of PhysConf and AnalysisConf in the end. This little PR simply removes a bit of code that is now redundant. More to come asap.

added cleanup label

@erodrigu So WIP: ?

I was thinking of doing small targeted PRs, so by start I meant more that this would be a first PR, not a WIP of a large one. My mail goal is of course the upgrade configuration, and I bumped into this possible clean-up looking at the code.

Now, I realise that this bit of code needs to be put into Davinci.Configuration.py since probably not there, whereas it is there already for Davinci.ConfigurationUpgrade.py. My bad, I was too quick trying to do something for the hackathon before the end of the day. I will create asap a PR in DaVinci and we can then merge both PRs.

Is that OK with you?

Ok. Good for me.

mentioned in merge request DaVinci!446 (merged)

The idea is to try and get rid of PhysConf and AnalysisConf for run 3. I have the feeling that this should be possible, and am convinced that it is the way to go, to avoid having many configurables passing on properties to other configurables, if possible.

Do you want to get this tested with all-slots?

Perhaps you are all already aware, but it's worth mentioning that we currently recommend using DaVinci for analysing Moore output. There isn't a test for this but it's a strong use case, so I would like to see this supported on master until DaVinci 2 is able to supersede what we have.

Thanks for your comment @apearce. Yes, totally makes sense. As I said, I had rushed and forgotten to also make the corresponding update targeting the good-old configurable in DaVinci/master. That's now done with DaVinci!446 (merged). So your use case is covered - these 2 related PRs simplify the configurables, nothing more. Agreed?

Yes, thank you!

added all-slots label

• [2020-10-24 00:08] Validation started with lhcb-lcg-dev4#1443
• [2020-10-24 00:08] Validation started with lhcb-lcg-dev3#1429
• [2020-10-24 00:08] Validation started with lhcb-sanitizers#703
• [2020-10-24 00:09] Validation started with lhcb-run3-cleanup#49
• [2020-10-24 00:14] Validation started with lhcb-head#2748
• [2020-10-24 00:14] Validation started with lhcb-dd4hep#669
• [2020-10-24 00:15] Validation started with lhcb-head-2#46
• [2020-10-24 00:22] Validation started with lhcb-new-cmake#206
• [2020-10-24 00:30] Validation started with lhcb-gaudi-head#2761
• [2020-10-25 00:08] Validation started with lhcb-lcg-dev3#1430
• [2020-10-25 00:08] Validation started with lhcb-sanitizers#704
• [2020-10-25 00:08] Validation started with lhcb-head-2#47
• [2020-10-25 00:08] Validation started with lhcb-run3-cleanup#50
• [2020-10-25 00:08] Validation started with lhcb-lcg-dev4#1444
• [2020-10-25 00:08] Validation started with lhcb-dd4hep#670
• [2020-10-25 00:08] Validation started with lhcb-head#2749
• [2020-10-25 00:08] Validation started with lhcb-gaudi-head#2762
• [2020-10-25 00:12] Validation started with lhcb-new-cmake#207
• [2020-10-25 00:28] Validation started with lhcb-coverity#530
• [2020-10-25 09:23] Validation started with lhcb-gaudi-head#2763
• [2020-10-26 00:08] Validation started with lhcb-dd4hep#671
• [2020-10-26 00:08] Validation started with lhcb-sanitizers#705
• [2020-10-26 00:08] Validation started with lhcb-lcg-dev3#1431
• [2020-10-26 00:09] Validation started with lhcb-gaudi-head#2764
• [2020-10-26 00:09] Validation started with lhcb-run3-cleanup#51
• [2020-10-26 00:14] Validation started with lhcb-head#2750
• [2020-10-26 00:14] Validation started with lhcb-head-2#48
• [2020-10-26 00:14] Validation started with lhcb-lcg-dev4#1445

@pkoppenb, this seems OK to be merged?

Indeed. All is fine.

closed

Why closed and not merged?

Yep - please reopen and merge :-). And then you can do the same for the related DaVinci PR. Thanks a lot.

reopened