Modernise PrintDecay
As an exercise of Gaudi::functional I transformed PrintDecay into a Consumer. But it appears its functionality is provided by a tool that is in Analysis, see the corresponding MR Analysis!741 (merged).
Changes remaining in Phys: make all methods const that can be const.
Tests needed fixing in DaVinci, DaVinci!494 (merged)
Merge request reports
Activity
mentioned in merge request Analysis!741 (merged)
added modernisation label
@sponce can you review this?
-
/ci-test --merge Analysis!741 (merged)
Started reference and integration test builds. Once done, check the comparison of build and test results.
Throughput Test Moore_hlt2_reco_baseline: 141.7 Events/s -- change of -0.02% vs. reference
Throughput Test Moore_hlt1_pp_default: 28761.9 Events/s -- change of -0.15% vs. reference
-
Hi @pkoppenb, I see some errors in DaVinci, can these be related to the MR?
Hi @lpica . Yes,
AttributeError: Configurable 'PrintDecayTree' does not have property 'Inputs'.is clearly this. I'll fix the options.
-
I saw that you added DaVinci!494 (merged), when they are ready for testing you can tag me (or maybe the next shifter).
added ci-test-triggered label
- [2020-12-17 16:01] Validation started with lhcb-master-mr#1763
- [2020-12-18 15:57] Validation started with lhcb-master-mr#1765
- [2020-12-20 00:15] Validation started with lhcb-head#2828
Edited by Software for LHCbmentioned in merge request DaVinci!494 (merged)
-
@lpica can you please check that DaVinci works now? Thanks
-
Perfect @pkoppenb,
/ci-test --merge Analysis!741 (merged) DaVinci!494 (merged)
Started reference and integration test builds. Once done, check the comparison of build and test results.
Throughput Test Moore_hlt2_reco_baseline: 141.7 Events/s -- change of -0.13% vs. reference
Throughput Test Moore_hlt1_pp_default: 28778.1 Events/s -- change of 0.11% vs. reference
mentioned in issue Moore#237 (closed)
added lhcb-head label
mentioned in commit Analysis@9ef4d3e7