Remove Phys/TeslaTools

This package is obsolete. It contains the old Turbo persistency.

It is now only used for 2015 EMTF Tesla matching tests. The corresponding TupleTool is removed in Analysis!748 (merged).

Work related to https://gitlab.cern.ch/lhcb-dpa/project/-/issues/8.

added cleanup lhcb-run3-cleanup labels

changed the description

changed the description

mentioned in merge request Analysis!748 (merged)

/ci-test --merge

added ci-test-triggered label

• [2021-02-08 14:15] Validation started with lhcb-master-mr#1858
• [2021-02-09 01:02] Validation started with lhcb-run3-cleanup#131
• [2021-02-10 00:38] Validation started with lhcb-run3-cleanup#132
• [2021-02-11 01:23] Validation started with lhcb-run3-cleanup#133

marked this merge request as draft

Marking as draft as it breaks Castelao.

TeslaTools is used in WG productions in Castelao. Is there any reason this would be needed in Run3? @cvazquez

It is used in

• WGProductions/WGProdTools/src/TurboFixByMatching.cpp : @landerli
• TrackCalib/TrackCalibProduction/src/CopyAndMatchCombinationTC.cpp : @rekopecn
• PIDCalib/PidCalibProduction/src/CopyAndMatchCombination.cpp : @poluekt @mborsato @landerli

I also note that the corresponding header files have no documentation whatsoever. This makes it hard to guess what they are good for. The suggested action is to remove from master the algorithms using TeslaTools. They will still be in run2-patches. Please comment if you think this is wrong.

Direct link to the nightlies: https://lhcb-nightlies.web.cern.ch/logs/build/nightly/lhcb-run3-cleanup/131/x86_64-centos7-gcc9-opt/Castelao/

About TrackCalib and PIDCalib, my knowledge is that they will move towards a python-based release for Run 3. I'm not sure about the tuple production though. I let @dhill and @malexand comment.

About WGProductions, I guess this will be superseded by the AnalysisProductions? or maybe I'm not right? @cburr @landerli .

Once this is clarified with the proponents, I can remove these packages from master.

@pkoppenb @cvazquez the most trivial fix for now would be to move this package to Castelao, on both master and run2-patches. That clarifies the usage of the package and the cleanup in Castelao can then be done when TrackCalib and PIDCalib evolve

OK, sounds good. @pkoppenb , feel free to to open a MR to Castelao/master. Thanks!

OK. Will do.

mentioned in merge request Castelao!94 (merged)

Move to Castelao : Castelao!94 (merged)

added backport run2 label

mentioned in merge request Analysis!757 (merged)

removed backport run2 label

mentioned in merge request Alignment!165 (merged)