Remove Phys/PhysDict

More clean-up, see https://gitlab.cern.ch/lhcb-dpa/project/-/issues/18.

Indeed this package adds dictionaries for very few instances,

<lcgdict>
  <!-- <class name = "std::pair<std::string, LHCb::HltDecReport>" /> -->
  <class name = "std::vector<std::pair<std::string, LHCb::HltDecReport> >" />
  <!-- <class name = "LHCb::HltDecReports::Container" /> -->
  <exclusion>
    <class pattern = "*HltDecReport*">
      <method name = "=="/>
      <method name = "<"/>
    </class>
  </exclusion>
  <class name = "std::vector<LHCb::RecVertex>" />
</lcgdict>

and some are already redundant, e.g. <class pattern = "*HltDecReport*">, see .

Checking the rest to make sure nothing else needs to be effectively moved from PhysDict to another package ...

FYI @pkoppenb (DPA) and @apearce and @rmatev (RTA).

added Core cleanup lhcb-run3-cleanup labels

changed the description

Also <class name = "std::vector<std::pair<std::string, LHCb::HltDecReport> >" /> is also declared already in https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/Event/HltEvent/dict/selection.xml.

The only remaining declaration to make sure it is somewhere is <class name = "std::vector<LHCb::RecVertex>" />. We do have similar ones in https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/Event/RecEvent/dict/selection.xml, in particular <class name="std::vector<LHCb::RecVertex*>"/> and <class name="std::vector<SmartRef<LHCb::RecVertex> >"/>. I can add there <class name = "std::vector<LHCb::RecVertex>" /> if that's thought to be necessary. Other than that this package is indeed redundant!

assigned to @pkoppenb

assigned to @mvesteri

Good spot. I have no idea what this package is doing.

(Just trying to help with clean-up when I bump into something ;-).)

This package is only making sure certain non-trivial instantiations are available in Python, creating the required dictionaries.

BTW, I updated the RTA PhysPackagesRefactor Google spreadsheet accordingly.

/ci-test --merge

added ci-test-triggered label

• [2021-02-16 16:25] Validation started with lhcb-master-mr#1882
• [2021-02-17 00:13] Validation started with lhcb-head#2868
• [2021-02-17 01:02] Validation started with lhcb-run3-cleanup#139

resolved all threads

added lhcb-head label

approved this merge request

Thank you both. Merging since I have karma :-).

merged

mentioned in commit da8fe69c

removed lhcb-head label

added DPA-WP3 label