Skip to content
Snippets Groups Projects
Marco Clemencic's avatar
commented on merge request !1116 "Draft: Workaround for a problem with template specialization and ROOT 6.32" at LHCb / Phys

See https://github.com/root-project/root/issues/18441

Marco Clemencic's avatar
commented on merge request !1116 "Draft: Workaround for a problem with template specialization and ROOT 6.32" at LHCb / Phys

I'm also going to report the bug to ROOT:...

Marco Clemencic's avatar
commented on merge request !1116 "Draft: Workaround for a problem with template specialization and ROOT 6.32" at LHCb / Phys

Correction, another minimal reproducer is...

Marco Clemencic's avatar
commented on merge request !1116 "Draft: Workaround for a problem with template specialization and ROOT 6.32" at LHCb / Phys

The problem is not GaudiPython though....

Marco Cattaneo's avatar
commented on merge request !1116 "Draft: Workaround for a problem with template specialization and ROOT 6.32" at LHCb / Phys

While investigating, I discovered that any LoKi test in Phys can be made to fail by simply adding import GaudiPython.GaudiAlgs to the test.

Software for LHCb's avatar
commented on merge request !1116 "Draft: Workaround for a problem with template specialization and ROOT 6.32" at LHCb / Phys
[2025-04-17 10:12] Validation started with lhcb-run2-patches#1706 ...
Marco Cattaneo's avatar
pushed to branch fixLoKi-Root632-run2 at LHCb / Phys
  • 5446b4aa · Workaround for a problem with template specialization and ROOT 6.32
Marco Cattaneo's avatar
opened merge request !1116 "Draft: Workaround for a problem with template specialization and ROOT 6.32" at LHCb / Phys
Marco Cattaneo's avatar
pushed new branch fixLoKi-Root632-run2 at LHCb / Phys
Marco Cattaneo's avatar
commented on merge request !1114 "Draft: FlavourTagging: New inclusive tagger" at LHCb / Phys

@vjevtic !1115 (merged) is now merged, you can proceed with the simplification

Vukan Jevtic's avatar
deleted branch development_tagger_v2 at LHCb / Phys
Marco Cattaneo's avatar
pushed to branch run2-patches at LHCb / Phys
Marco Cattaneo's avatar
accepted merge request !1115 "Development tagger v2" at LHCb / Phys
Vukan Jevtic's avatar
pushed to branch development_tagger_v2 at LHCb / Phys
Vukan Jevtic's avatar
pushed to branch development_tagger_v2 at LHCb / Phys
Vukan Jevtic's avatar
commented on merge request !1115 "Development tagger v2" at LHCb / Phys

But this would cleanup the merge commit message, right? Give me a moment I guess. EDIT: Done. Whether you want to squash the commits is up to you know

Vukan Jevtic's avatar
commented on merge request !1115 "Development tagger v2" at LHCb / Phys

I set the branches in both MR's to be deleted and the commits to be squashed, does this not mean that they will all be compressed into one set of c...

Mark Smith's avatar
approved merge request !1115 "Development tagger v2" at LHCb / Phys
Marco Cattaneo's avatar
commented on merge request !1115 "Development tagger v2" at LHCb / Phys

@vjevtic if you have a moment (and you know how to do it), it would be good if you would cleanup the commit history before we merge

Marco Cattaneo's avatar
approved merge request !1115 "Development tagger v2" at LHCb / Phys