Inconsistency in decision names saved to DecReport between Hlt1 and Hlt2 lines

Both HLT1 and HLT2 lines AFAIK have ‘Line’ as suffix in their names.

When storing their decisions in DV, for Hlt1 I have to remove the suffix Line from it (i.e. change Hlt1TrackMVALine -> Hlt1TrackMVA) whereas for Hlt2 I have to keep the suffix Line. Is there a reason for this inconsistency? [Note: DV prepends suffix Decision if not found]

FYI: @erodrigu , @pkoppenb and @nskidmor

added DPA-WP3 enhancement labels

I am not sure who to assign it to so ping the shifter @peilian

Thanks @amathad I think this is a simple case of incoherent conventions in Allen and Moore

@thboettc @mstahl could you please discuss (also with whoever else you consider relevant) make a decision how to align things and then align them? Obviously @nskidmor should sign off on this for sprucing also. I have no strong view either way.

Well spotted @amathad. So you're basically saying that the "conventional expressions" https://gitlab.cern.ch/lhcb/Moore/-/blob/master/Hlt/Moore/python/Moore/config.py#L40-42 and https://gitlab.cern.ch/lhcb/Moore/-/blob/master/Hlt/Moore/python/Moore/lines.py#L40-41 are not imposed everywhere. In particular, the function https://gitlab.cern.ch/lhcb/Moore/-/blob/master/Hlt/Moore/python/Moore/config.py#L914-919 seems unused for HLT1 lines? Personally I'm all for conventions (for various reasons) but let's see what HLT1 responsibles and others say.

I don't think we can easily use a function in Moore to impose a line naming convention on Allen. But once a convention is agreed it should not be so hard to follow it everywhere.

Exactly. It's an implementation detail :-).

The cleanest would probably be to remove the Line suffix in Hlt2. I can try to make a MR next week. Allen would have nothing to change iiuc and DV can also get rid of code that looks for or appends Line.

The promised MR is Moore!1730 (merged). Sorry for the delay. Please take a look and let me know what is missing (at this stage most likely a lot in projects depending on Moore).

This will have some impact on open merge requests as well and we should inform people if we're going down that road.

FYI @amathad @erodrigu @gligorov @nskidmor @peilian @pkoppenb @thboettc

Thanks a lot @mstahl for aligning them!

mentioned in merge request Moore!1730 (merged)

closed with merge request Moore!1730 (merged)

mentioned in commit Moore@5e614da8