[0KRunning with gitlab-runner 17.8.3 (690ce25c)[0;m
[0K on runners-k8s-default-runners-c4c985b47-hgpqw Z8Jooa6tn, system ID: r_s2aRmI3ucu0J[0;m
[0K feature flags: FF_USE_ADVANCED_POD_SPEC_CONFIGURATION:true[0;m
[0K[36;1mResolving secrets[0;m[0;m
section_start:1742919807:prepare_executor
[0K[0K[36;1mPreparing the "kubernetes" executor[0;m[0;m
[0KUsing Kubernetes namespace: gitlab[0;m
[0KUsing Kubernetes executor with image registry.cern.ch/docker.io/library/python:3.10 ...[0;m
[0KUsing attach strategy to execute scripts...[0;m
section_end:1742919807:prepare_executor
[0Ksection_start:1742919807:prepare_script
[0K[0K[36;1mPreparing environment[0;m[0;m
[0KUsing FF_USE_POD_ACTIVE_DEADLINE_SECONDS, the Pod activeDeadlineSeconds will be set to the job timeout: 1h0m0s...[0;m
[0;33mWARNING: Advanced Pod Spec configuration enabled, merging the provided PodSpec to the generated one. This is a beta feature and is subject to change. Feedback is collected in this issue: https://gitlab.com/gitlab-org/gitlab-runner/-/issues/29659 ...[0;m
Waiting for pod gitlab/runner-z8jooa6tn-project-401-concurrent-0-1vp1hntd to be running, status is Pending
Waiting for pod gitlab/runner-z8jooa6tn-project-401-concurrent-0-1vp1hntd to be running, status is Pending
ContainersNotReady: "containers with unready status: [build helper]"
ContainersNotReady: "containers with unready status: [build helper]"
Waiting for pod gitlab/runner-z8jooa6tn-project-401-concurrent-0-1vp1hntd to be running, status is Pending
ContainersNotReady: "containers with unready status: [build helper]"
ContainersNotReady: "containers with unready status: [build helper]"
Running on runner-z8jooa6tn-project-401-concurrent-0-1vp1hntd via runners-k8s-default-runners-c4c985b47-hgpqw...
section_end:1742919816:prepare_script
[0Ksection_start:1742919816:get_sources
[0K[0K[36;1mGetting source from Git repository[0;m[0;m
[32;1mFetching changes...[0;m
Initialized empty Git repository in /builds/lhcb/Rec/.git/
[32;1mCreated fresh repository.[0;m
[32;1mChecking out 55851952 as detached HEAD (ref is refs/merge-requests/4249/head)...[0;m
[32;1mSkipping Git submodules setup[0;m
section_end:1742919831:get_sources
[0Ksection_start:1742919831:restore_cache
[0K[0K[36;1mRestoring cache[0;m[0;m
[32;1mChecking cache for default-non_protected...[0;m
Downloading cache from https://s3.cern.ch/swarmcache/swarmcache/project/401/default-non_protected[0;m ETag[0;m="18f5c5344585515b043fcd5fd2e83ad3"
[32;1mSuccessfully extracted cache[0;m
section_end:1742919833:restore_cache
[0Ksection_start:1742919833:step_script
[0K[0K[36;1mExecuting "step_script" stage of the job script[0;m[0;m
[32;1m$ # INFO: Lowering limit of file descriptors for backwards compatibility. ffi: https://cern.ch/gitlab-runners-limit-file-descriptors # collapsed multi-line command[0;m
[32;1m$ python -m venv ${CI_PROJECT_DIR}/.cache/pre-commit-venv # collapsed multi-line command[0;m
Collecting pre-commit
Downloading pre_commit-4.2.0-py2.py3-none-any.whl (220 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 220.7/220.7 kB 6.9 MB/s eta 0:00:00
Collecting nodeenv>=0.11.1
Downloading nodeenv-1.9.1-py2.py3-none-any.whl (22 kB)
Collecting identify>=1.0.0
Downloading identify-2.6.9-py2.py3-none-any.whl (99 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 99.1/99.1 kB 51.1 MB/s eta 0:00:00
Collecting pyyaml>=5.1
Downloading PyYAML-6.0.2-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (751 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 751.2/751.2 kB 49.1 MB/s eta 0:00:00
Collecting cfgv>=2.0.0
Downloading cfgv-3.4.0-py2.py3-none-any.whl (7.2 kB)
Collecting virtualenv>=20.10.0
Downloading virtualenv-20.29.3-py3-none-any.whl (4.3 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 4.3/4.3 MB 118.9 MB/s eta 0:00:00
Collecting platformdirs<5,>=3.9.1
Downloading platformdirs-4.3.7-py3-none-any.whl (18 kB)
Collecting filelock<4,>=3.12.2
Downloading filelock-3.18.0-py3-none-any.whl (16 kB)
Collecting distlib<1,>=0.3.7
Downloading distlib-0.3.9-py2.py3-none-any.whl (468 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 kB 142.3 MB/s eta 0:00:00
Installing collected packages: distlib, pyyaml, platformdirs, nodeenv, identify, filelock, cfgv, virtualenv, pre-commit
Successfully installed cfgv-3.4.0 distlib-0.3.9 filelock-3.18.0 identify-2.6.9 nodeenv-1.9.1 platformdirs-4.3.7 pre-commit-4.2.0 pyyaml-6.0.2 virtualenv-20.29.3
[notice] A new release of pip is available: 23.0.1 -> 25.0.1
[notice] To update, run: pip install --upgrade pip
From https://gitlab.cern.ch/lhcb/Rec
* branch master -> FETCH_HEAD
[32;1m$ if ! pre-commit run --show-diff-on-failure --from-ref FETCH_HEAD --to-ref HEAD ; then # collapsed multi-line command[0;m
test inputs use TestFileDB...........................(no files to check)Skipped
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook
Fixing Tr/TrackMonitors/src/UTGlobalEffMon.cpp
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
clang-format.............................................................Failed
- hook id: clang-format
- files were modified by this hook
clang-format (non-standard extensions)...............(no files to check)Skipped
ruff.................................................(no files to check)Skipped
ruff-format..........................................(no files to check)Skipped
All changes made by hooks:
diff --git a/Tr/TrackMonitors/src/UTGlobalEffMon.cpp b/Tr/TrackMonitors/src/UTGlobalEffMon.cpp
index 607a75971c..1d3698ad3b 100644
--- a/Tr/TrackMonitors/src/UTGlobalEffMon.cpp
+++ b/Tr/TrackMonitors/src/UTGlobalEffMon.cpp
@@ -61,7 +61,7 @@ namespace LHCb::UT {
UTGlobalEffMon( const std::string& name, ISvcLocator* pSvcLocator );
void operator()( Track::Range const& tracks, DetectorElement const& ) const override;
template <typename TFitResult>
- void monitor( const TFitResult* , LHCb::Track const* , const DetectorElement& , unsigned int ) const;
+ void monitor( const TFitResult*, LHCb::Track const*, const DetectorElement&, unsigned int ) const;
private:
mutable Gaudi::Accumulators::Histogram<1> m_h_ntracks{
@@ -121,13 +121,14 @@ namespace LHCb::UT {
: Consumer(
name, pSvcLocator,
{ { "TracksInContainer", TrackLocation::Default }, { "StandardGeometryTop", standard_geometry_top } } ) {}
-
+
template <typename TFitResult>
- void UTGlobalEffMon::monitor( const TFitResult* fitResult, LHCb::Track const* track, const DetectorElement& lhcb, unsigned int nTracks ) const {
- auto& geometry = *lhcb.geometry();
+ void UTGlobalEffMon::monitor( const TFitResult* fitResult, LHCb::Track const* track, const DetectorElement& lhcb,
+ unsigned int nTracks ) const {
+ auto& geometry = *lhcb.geometry();
const double zutlay3 = 2652.5;
const double UT_sensor_width = 95.6; // do not change this because you think this is not correct!
- StateVector aState;
+ StateVector aState;
extrapolator()->propagate( *track, zutlay3, aState, geometry ).ignore();
if ( aState.x() < -9990 ) { return; } // Skip unphysical tracks
@@ -205,18 +206,20 @@ namespace LHCb::UT {
++m_h_nutlay[nlay];
if ( nlay > 0 ) ++m_h_pass3_low_mult[{ tr2utlax3, tr2utlay3 }];
}
-
}
void UTGlobalEffMon::operator()( Track::Range const& tracks, const DetectorElement& lhcb ) const {
- int nTracks = tracks.size();
+ int nTracks = tracks.size();
if ( nTracks > 10000 ) { nTracks = 10000; } // saturation
++m_h_ntracks[nTracks];
for ( const Track* track : tracks ) {
- if ( auto fitResult = dynamic_cast<const TrackFitResult*>( track->fitResult() ); fitResult ) { monitor(fitResult, track, lhcb,nTracks); }
- else if ( auto fitResult = dynamic_cast<const PrKalmanFitResult*>( track->fitResult() ); fitResult ) { monitor(fitResult,track, lhcb,nTracks); }
+ if ( auto fitResult = dynamic_cast<const TrackFitResult*>( track->fitResult() ); fitResult ) {
+ monitor( fitResult, track, lhcb, nTracks );
+ } else if ( auto fitResult = dynamic_cast<const PrKalmanFitResult*>( track->fitResult() ); fitResult ) {
+ monitor( fitResult, track, lhcb, nTracks );
+ }
}
}
} // namespace LHCb::UT
Generating patch file...
0001-pre-commit-fixes.patch
=======================================
You can apply these changes with:
curl https://gitlab.cern.ch/lhcb/Rec/-/jobs/53283296/artifacts/raw/0001-pre-commit-fixes.patch | git am
=======================================
section_end:1742919839:step_script
[0Ksection_start:1742919839:upload_artifacts_on_failure
[0K[0K[36;1mUploading artifacts for failed job[0;m[0;m
[32;1mUploading artifacts...[0;m
0001-pre-commit-fixes.patch: found 1 matching artifact files and directories[0;m
Uploading artifacts as "archive" to coordinator... 201 Created[0;m id[0;m=53283296 responseStatus[0;m=201 Created token[0;m=glcbt-64
section_end:1742919839:upload_artifacts_on_failure
[0Ksection_start:1742919839:cleanup_file_variables
[0K[0K[36;1mCleaning up project directory and file based variables[0;m[0;m
section_end:1742919840:cleanup_file_variables
[0K[31;1mERROR: Job failed: command terminated with exit code 1
[0;m