follow LHCb!2099
- rename Calo::Future into LHCb::Calo
- follow changes in CaloFutureUtils
- prefer string_view where appropriate
- avoid declaring uninitialized variables
- prefer std::optional over 'special values'
- avoid functions with lots of arguments of the same type -- instead define a dedicated struct so the variables can be explicitly named
- prefer std::copy, std::transform over explicit loop
to be applied in conjunction with LHCb!2099 (merged)
Edited by Marco Cattaneo
Merge request reports
Activity
mentioned in merge request LHCb!2099 (merged)
added 2 commits
-
89a84642 - 1 commit from branch
master
- 1ef25a3e - Follow LHCb!2099 (merged) + cleanup
-
89a84642 - 1 commit from branch
- [2019-09-10 00:11] Validation started with lhcb-tdr-test#668
- [2019-09-11 00:18] Validation started with lhcb-tdr-test#669
- [2019-09-12 00:14] Validation started with lhcb-tdr-test#670
- [2019-09-12 12:29] Validation started with lhcb-tdr-test#671
- [2019-09-13 00:11] Validation started with lhcb-tdr-test#672
- [2019-09-13 15:20] Validation started with lhcb-dd4hep#315
- [2019-09-14 00:08] Validation started with lhcb-sanitizers#370
- [2019-09-14 00:08] Validation started with lhcb-dd4hep#316
- [2019-09-14 00:08] Validation started with lhcb-lcg-dev4#1030
- [2019-09-14 00:10] Validation started with lhcb-test-throughput2#151
- [2019-09-14 00:12] Validation started with lhcb-gaudi-head#2385
- [2019-09-14 00:12] Validation started with lhcb-tdr-test#673
- [2019-09-14 00:13] Validation started with lhcb-head#2366
- [2019-09-14 00:36] Validation started with lhcb-lcg-dev4#1030
- [2019-09-15 00:06] Validation started with lhcb-dd4hep#317
- [2019-09-15 00:07] Validation started with lhcb-head#2367
- [2019-09-15 00:07] Validation started with lhcb-gaudi-head#2386
- [2019-09-15 00:08] Validation started with lhcb-lcg-dev4#1031
- [2019-09-15 00:08] Validation started with lhcb-sanitizers#371
- [2019-09-15 00:09] Validation started with lhcb-test-throughput2#152
- [2019-09-15 00:12] Validation started with lhcb-lcg-dev3#1021
- [2019-09-15 00:13] Validation started with lhcb-tdr-test#674
- [2019-09-15 00:27] Validation started with lhcb-coverity#472
- [2019-09-16 00:06] Validation started with lhcb-dd4hep#318
- [2019-09-16 00:07] Validation started with lhcb-sanitizers#372
- [2019-09-16 00:08] Validation started with lhcb-lcg-dev4#1032
- [2019-09-16 00:08] Validation started with lhcb-lcg-dev3#1022
- [2019-09-16 00:09] Validation started with lhcb-test-throughput2#153
- [2019-09-16 00:10] Validation started with lhcb-gaudi-head#2387
- [2019-09-16 00:12] Validation started with lhcb-tdr-test#675
- [2019-09-16 00:14] Validation started with lhcb-head#2368
Edited by Software for LHCb- Resolved by Marco Cattaneo
@graven there is something going wrong with the printout of a counter, that QMTest is not able to parse:
File "/workspace/build/LHCb/InstallArea/x86_64-centos7-gcc8-opt/python/GaudiConf/QMTest/LHCbTest.py", line 24, in _floatDiffer val = float(val) ValueError: could not convert string to float: ( 0.000000 +- 0.000000)%
See failing Brunel tests in https://lhcb-nightlies.cern.ch/logs/tests/nightly/lhcb-tdr-test/668/x86_64-centos7-gcc8-opt/Brunel/
mentioned in merge request Brunel!879 (merged)
mentioned in issue #84 (closed)
Please register or sign in to reply