Masked and fixed AVX512 compilation warnings
The ones that could be "fixed", aka where vectorclass was actually not used, have been fixed. For the others, I've declared vectorclass as a system library.
Note that this should fix (and not mask) also all the warnings in Phys and Analysis repositories.
Also note that the majority of vectorclass usages (if not all ?) is coming from the code of the VectorFitter, even if this code is spread a bit everywhere. Dropping it would help a lot removing vectorclass.
Merge request reports
Activity
- Resolved by Marian Stahl
Shall we flag this with lhcb-head, as for LHCb!2304 (merged) ? The problem is that ci-test is of no use here as we need the avx512 build.
Edited by Sebastien Ponce
added lhcb-head label
assigned to @mstahl
- [2020-01-09 00:09] Automatic merge failed in lhcb-head#2477
- [2020-01-10 00:12] Validation started with lhcb-gaudi-head#2498
- [2020-01-11 00:11] Validation started with lhcb-gaudi-head#2499
Edited by Software for LHCb- Resolved by Sebastien Ponce
This is now clashing with !1851 (merged) so was not applied in the nightlies. Could !1851 (merged) be merged so that I can rebase ?
Edited by Rosen Matev
added 5 commits
-
793cc591...8185f930 - 3 commits from branch
master
- 658867b9 - Avoided a lot of compiilation warnings on AVX512 by disentangling code
- ca05082d - Declared vectorclass as a system header to mask compilation warnings on AVX512
-
793cc591...8185f930 - 3 commits from branch
added lhcb-gaudi-head label and removed lhcb-head label
added 4 commits
-
ca05082d...0019e9e7 - 2 commits from branch
master
- 9a0511d1 - Avoided a lot of compiilation warnings on AVX512 by disentangling code
- 6cc92a8e - Declared vectorclass as a system header to mask compilation warnings on AVX512
-
ca05082d...0019e9e7 - 2 commits from branch
@sponce Thanks, this looks very good! A quick question on the latest commit, since I have trouble to disentangle the diffs: the changes in PrChecker are from !1844 (merged) , and what fixes the 2 remaining warnings are the 2 lines in
Tr/TrackFitter
's CMakeLists?added Build label and removed lhcb-gaudi-head label
added cleanup label