Modernize PatPV
- amalgamate component headers into their source files
- prefer span over const vector&
- prefer inherited constructors
- prefer pragma once
Merge request reports
Activity
added backport run2 cleanup labels
added 4 commits
-
5c17218b...501ad474 - 3 commits from branch
master
- 3358c0a9 - Modernize PatPV
-
5c17218b...501ad474 - 3 commits from branch
added 54 commits
-
3358c0a9...3c55e85c - 53 commits from branch
master
- 6bb1c985 - Modernize PatPV
-
3358c0a9...3c55e85c - 53 commits from branch
added 3 commits
-
6bb1c985...f1a7b2c7 - 2 commits from branch
master
- b9305a4f - Modernize PatPV
-
6bb1c985...f1a7b2c7 - 2 commits from branch
@graven please, in future MRs of that sort, try to separate at least the move of declarations in one commit. It's already nearly impossible to review the diff unless I/someone dedicate/s/ an unreasonable amount of time.
mentioned in issue Moore#128 (closed)
assigned to @adudziak
@adudziak Can you suggest someone else to have a look at this or would you like to still?
@rcurrie yes! I went through some part of it already. Since I had to take a couple days off I am a bit delayed with my to-do list. Sorry!
- Resolved by Dorothea Vom Bruch
@adudziak No worries, was only trying to lighten the load if possible, if you're happy to review please continue
mentioned in issue Moore#131 (closed)
- Resolved by Gerhard Raven
mentioned in issue Moore#141 (closed)
mentioned in issue Moore#148 (closed)
mentioned in issue Moore#158 (closed)
added 316 commits
-
b9305a4f...7d5d2d0e - 315 commits from branch
master
- 5f9f7359 - Modernize PatPV
-
b9305a4f...7d5d2d0e - 315 commits from branch
- [2020-04-16 15:04] Validation started with lhcb-master-mr#679
added modernisation label and removed cleanup label
added PV finding label
unassigned @rmatev
mentioned in commit abd74b42
mentioned in issue Moore#163 (closed)