Skip to content
Snippets Groups Projects

Use `std::variant` to represent corrections in `CaloFutureCorrectionBase`

Merged Use `std::variant` to represent corrections in `CaloFutureCorrectionBase`
issue-121 into master
Merged Gerhard Raven requested to merge issue-121 into master

Use an std::variant to represent the various corrections. This allows the error checking and correction specific caching to be moved into each individual correction.

It also addresses some (most?) comments made as part of #121

Edited by Gerhard Raven

Merge request reports

Pipeline #1380285 passed

Stage: test

Pipeline passed for 455e93c4 on issue-121

Approval is optional

Merged by Rosen MatevRosen Matev 5 years ago (Feb 3, 2020 4:40pm UTC)

Merge details

  • Changes merged into master with 9261bc38.
  • Deleted the source branch.

  • Mentions issue #121

Pipeline #1387537 passed

Stage: test

Pipeline passed for 9261bc38 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply