Declare data dependencies in ThOr functors

By implementing the data_dependencies API added in LHCb!2930 (merged), PyConf can now retrieve data dependencies of functors. The various BoundFunctor specialisations now propagate the dependencies of their inputs to themselves. Complex functors, like MVA and COMB, are responsible for propagating data dependencies from their arguments (which is rather ugly, but I think it's good enough for now).

To support existing tests and allow for gradual migration, strings are allowed in place of DataHandle arguments, but a warning is logged. Users of functors should migrate to using DataHandle.

See Moore#51 (closed) for further motivation.

Requires LHCb!2930 (merged).

added 2 commits

• 6b8a39f0 - Use pytest rather than nosetests.
• f795cdfc - Functors now declare DataHandle dependencies.

Compare with previous version

added Configuration Functors ThOr labels

mentioned in commit Moore@b668b47d

mentioned in merge request Moore!738 (merged)

changed the description

mentioned in commit Moore@a0d24f16

• [2021-02-12 16:08] Validation started with lhcb-master-mr#1870
• [2021-02-15 14:18] Validation started with lhcb-master-mr#1876
• [2021-02-16 16:14] Validation started with lhcb-master-mr#1880
• [2021-02-17 00:10] Validation started with lhcb-head-2#167
• [2021-02-17 01:24] Validation started with lhcb-head-2#167

added 1 commit

• 0c242c42 - Add explicit pickle support to BoundFunctor.

Compare with previous version

resolved all threads

assigned to @frodrigu

added lhcb-head-2 label

@rmatev there is a failure in pipelines documents test of Moore!738 (merged), but the results of the ci-test and LHCb-head-2 #167 are good (see Moore!738 (merged)).

assigned to @rmatev and unassigned @frodrigu

added enhancement label

requested review from @rmatev and removed review request for @nnolte

removed lhcb-head-2 label

added 15 commits

• 0c242c42...687a2098 - 12 commits from branch master
• 3dd104cd - Use pytest rather than nosetests.
• a1baedd0 - Functors now declare DataHandle dependencies.
• 2594829a - Add explicit pickle support to BoundFunctor.

Compare with previous version

resolved all threads

approved this merge request

unassigned @rmatev

merged

mentioned in commit 466c09ac

We unfortunately missed some new warnings in Rec: https://lhcb-nightlies.web.cern.ch/logs/build/nightly/lhcb-master/1321/x86_64-centos7-gcc9-opt/Rec/

# WARNING: String '' given as substitute for DataHandle; PyConf will not be able to infer this data dependency	
# WARNING: String '/Event/SOME/DUMMY/PATH' given as substitute for DataHandle; PyConf will not be able to infer this data dependency	
# WARNING: String 'Fake/Tracks' given as substitute for DataHandle; PyConf will not be able to infer this data dependency

@apearce can you take a look?

mentioned in issue #186 (closed)

resolved all threads