Skip to content
Snippets Groups Projects

Declare data dependencies in ThOr functors

Merged Declare data dependencies in ThOr functors
apearce-moore-51 into master
Merged Alex Pearce requested to merge apearce-moore-51 into master
  1. Feb 18, 2021
    • Alex Pearce's avatar
      Add explicit pickle support to BoundFunctor. · 2594829a
      Alex Pearce authored 
      This allows functors with DataHandle data dependencies to be serialised.
As PyConf.Algorithm makes no guarantees about serialisation, we drop it
during serialisation, relying on the TES location encoded in the functor
string representation to implicitly preserve the data dependency.
      2594829a
    • Alex Pearce's avatar
      Functors now declare DataHandle dependencies. · a1baedd0
      Alex Pearce authored 
      By implementing the `data_dependencies` API added in LHCb!2930, PyConf
can now retrieve data dependencies of functors. The various BoundFunctor
specialisations now propagate the dependencies of their inputs to
themselves. Complex functors, like MVA and COMB, are responsible for
propagating data dependencies from their arguments.

To support existing tests and allow for gradual migration, strings are
allowed in place of DataHandle arguments, but a warning is logged. Users
of functors should migrate to using DataHandle.

See Moore#51 for further motivation.
      a1baedd0
    • Alex Pearce's avatar
      Use pytest rather than nosetests. · 3dd104cd
      Alex Pearce authored 
      Follows usage elsewhere in the stack, e.g. PyConf and Moore.
      3dd104cd