add assert to AddHit to validate input
(and move the #include statements around)
Motivated by #193 (closed)
Merge request reports
Activity
added cleanup label
added 1 commit
- 1140ebc4 - add assert to AddHit and UTGeomCache to validate input
added 1 commit
- 678e552b - add assert to AddHit and UTGeomCache to validate input
added 1 commit
- 8dee4670 - add assert to AddHit and UTGeomCache to validate input
added 1 commit
- e70441f4 - add assert to AddHit and UTGeomCache to validate input
added 1 commit
- 428acbf4 - add assert to AddHit and UTGeomCache to validate input
assigned to @jbaptist
Resolved by Christopher Rob Jones@graven please let me know when it can be tested.
added 1 commit
- 2fd66dfb - add assert to AddHit and UTGeomCache to validate input
Resolved by Christopher Rob Jones@graven does this fix already #193 (closed) or is it just a first step towards it?
added ci-test-triggered label
- [2021-04-12 22:58] Validation started with lhcb-master-mr#2182
- [2021-04-28 12:12] Validation started with lhcb-master-mr#2258
Edited by Software for LHCb-
Hi @graven, both clang 8 platforms launched the same warning msg:
LHCb/InstallArea/x86_64-centos7-clang8-opt/include/Kernel/UTDecoder.h:33:1: warning: 'UTDecoder' defined as a struct template here but previously declared as a class template; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags]
- Resolved by Christopher Rob Jones
That's independent / separate of this MR -- and fixed here which is part of LHCb!2997 (merged).
- Last reply by Rosen Matev
mentioned in issue #193 (closed)
mentioned in issue Moore#272 (closed)
assigned to @rmatev
