Bug fix and add functors FOURMOMENTUM, PX, PY, PZ and ENERGY

Include a bug fix in the helper function for energy and adds the following functors:

• P{X,Y,Z} and ENERGY should work on both v1 and v2 particles.
• FOURMOMENTUM returns a Gaudi::LorentzVector and should work on both v1 and v2 particles.

FYI: @erodrigu , @pkoppenb , @mferrill , @powen , @cchen2

added DPA-WP3 Functors ThOr labels

assigned to @amathad

Nice update ! It is good to ping RTA colleagues for cross-project work - @mvesteri and @poluekt.

Quick question from me (did not compare both codes): what is the difference between MASS and MM? We've had discussions on these 2 also in legacy code and better be sure that we do need both.

(And link, of course, to the relevant DPA task ;-).)

changed title from Add functors FOURMOMENTUM, PX, PY, PZ, PE, MM and MM_ERR to Add functors FOURMOMENTUM, PX, PY, PZ and PE

changed the description

added 1 commit

• 4cbea88d - Remove MM and MM_ERR functors

Compare with previous version

Is there a functor left that returns a mass error?

mentioned in issue Moore#351 (closed)

assigned to @lpica

Hi @amathad, any news on this?

added 1 commit

• 412604bb - Fixed formatting

Compare with previous version

added 72 commits

• 412604bb...6f636bb6 - 71 commits from branch master
• a693340c - Merge branch 'master' into chenchen

Compare with previous version

added 1 commit

• 0096d161 - modifications to include functor library itself

Compare with previous version

added 1 commit

• 30b6e2b5 - Fixed formatting

Compare with previous version

changed the description

mentioned in merge request DaVinci!595 (merged)

For v1 there is an MR (DaVinci!595 (merged)) with unit test. Are there pre-existing tests for v2 that I can add these functors to?

Also an FYI (@mvesteri and @pkoppenb ): As there was talk of doing vector algebra with ThOr functors in this thread, here I had an option for F.FOURMOMENTUM to return ROOT::Math::PxPyPzEVector or LHCb::LinAlg::Vec<T, 4> (which is used everywhere within ThOr and for v2). I thought of adding a flag to return either of them, but went for ROOT option as it is well supported.




added 1 commit

• 4424c1c0 - rename PE to ENERGY

Compare with previous version

changed title from Add functors FOURMOMENTUM, PX, PY, PZ and PE to Add functors FOURMOMENTUM, PX, PY, PZ and ENERGY