Fix and clean-up TrackResChecker

In this MR the input of TrackResChecker is changed to LHCb::Tracks to avoid possible bugs when using Track::Selection, see Moore!1015 (merged). Also includes a small clean-up of unused properties.

Goes with Moore!1015 (merged)

Tr/TrackCheckers/src/TrackResChecker.cpp

@@ -38,8 +38,8 @@
  */
 
 class TrackResChecker
-    : public Gaudi::Functional::Consumer<void( LHCb::Track::Range const&, LHCb::MCParticles const&,
-                                               LHCb::LinksByKey const&, DetectorElement const& ),
+    : public Gaudi::Functional::Consumer<void( LHCb::Tracks const&, LHCb::MCParticles const&, LHCb::LinksByKey const&,
+                                               DetectorElement const& ),
                                          LHCb::DetDesc::usesBaseAndConditions<TrackCheckerBase, DetectorElement>> {
 
 public:
@@ -50,7 +50,7 @@ public:
   StatusCode initialize() override;
 
   /** Algorithm execute */
-  void operator()( LHCb::Track::Range const&, LHCb::MCParticles const&, LHCb::LinksByKey const&,
+  void operator()( LHCb::Tracks const&, LHCb::MCParticles const&, LHCb::LinksByKey const&,
                    DetectorElement const& ) const override;
 
   /** Algorithm finalize */
@@ -71,10 +71,6 @@ private:
 private:
   Gaudi::Property<bool> m_plotsByMeasType{this, "PlotsByMeasType", false};
 
-  typedef LinkedTo<LHCb::MCParticle> OTLinks;
-  Gaudi::Property<unsigned int>      m_minToCountAmb{this, "MinToCountAmb", 8};
-  Gaudi::Property<double>            m_minAmbDist{this, "MinAmbDist", 0.3 * Gaudi::Units::mm};
-
   ToolHandle<ITrackProjectorSelector>      m_projectorSelector{this, "ProjectorSelector",
                                                           "TrackProjectorSelector/Projector"};
   typedef std::map<int, const IHistoTool*> HistoToolMap;
@@ -120,7 +116,7 @@ const IHistoTool* TrackResChecker::createHistoTool( const std::string& name ) co
 //=============================================================================
 // Execute
 //=============================================================================
-void TrackResChecker::operator()( LHCb::Track::Range const& tracks, LHCb::MCParticles const& mcParts,
+void TrackResChecker::operator()( LHCb::Tracks const& tracks, LHCb::MCParticles const& mcParts,
                                   LHCb::LinksByKey const& links, DetectorElement const& lhcb ) const {
 
   // loop over them