Modify Combination functors to accept LHCb::Particle inputs
Modify DOCA Functors, and MIN
and MAX
functors to allow for LHCb::Particle
input. This allows for their use in ParticleFilter
. Closes Moore#355 (closed).
Merge request reports
Activity
- Resolved by Alexander Leon Gilman
@nnolte I can pick it up, just from a glance looks like youve introduced a coverter from
LHCb::Particle
toParticleCombination
?
added RTA label
- Resolved by Alexander Leon Gilman
is this even necessary with this in place?
assigned to @agilman
- Resolved by Alexander Leon Gilman
Where are we with this MR ? Is it still in progress ? ready to test ? Or should it be closed as @graven comment seems to suggest ?
added 1942 commits
-
592f6a16...d00b849b - 1938 commits from branch
master
- 771665b7 - Merge branch 'master' into NN_comb
- bee2833a - Merge branch 'master' into NN_comb
- d80fdc72 - Merge branch 'master' into NN_comb
- 8d84bb6d - Add type-switching to MIN and MAX
Toggle commit list-
592f6a16...d00b849b - 1938 commits from branch
added Functors label
Started integration test build. Once done, check the results or the comparison to a reference build.
Throughput Test Moore_hlt2_reco_baseline: 173.0 Events/s -- change of -0.34% vs. reference
Throughput Test Moore_hlt2_fastest_reco: 430.4 Events/s -- change of -0.72% vs. reference
Throughput Test Moore_hlt2_pp_thor: 320.2 Events/s -- change of 0.30% vs. reference
Throughput Test Moore_hlt1_pp_default: 28571.3 Events/s -- change of 0.18% vs. reference
@lmeyerga Tests all look good. @mvesteri @poluekt you both ok with this getting merged in it's current state?
Edited by Alexander Leon GilmanCan this be labeled as closing Moore#355 (closed)?
@lmeyerga I've added new functionality here and a dependent MR in
LHCb
. Can you run a new set of test with the dependent MR?Edited by Alexander Leon Gilman
added ci-test-triggered label
- [2022-01-26 16:24] Validation started with lhcb-master-mr#3547