Skip to content
Snippets Groups Projects

Modify ParticleCombination to make the type independent of the number of particles, remove DOCA{,Chi2} computation from combinations classes

Merged Gerhard Raven requested to merge tweak-ParticleCombination into master
  • basically, change std::array to std::vector while keeping the 'outer' class backwards compatible
  • change is required to be able to create a ParticleCombination from a (composite) LHCb::Particle
  • remove computation of DOCA{,Chi2} from the combinations, and move it into relevant functors themselves
  • add interfaces to combinations to allow the above point, namely: get, transform_reduce, pairwise_transform_reduce, pairwise_none_of
  • double the number of doca-related functors: one set which uses a simple 'one state only' computation (prefixed with S, eg. SDOCA, with S for 'state'), and one set, the old and new default (which uses the IDistanceCalculator tool instead) -- but the latter only works for LHCb::Particle as the interface doesn't accept v2 classes...

Requires LHCb!3404 (merged), Moore!1301 (merged)

Edited by Gerhard Raven

Merge request reports

Merge request pipeline #3562583 passed

Merge request pipeline passed for 9023ee63

Approved by

Merged by Rosen MatevRosen Matev 3 years ago (Feb 12, 2022 8:14pm UTC)

Merge details

  • Changes merged into master with d8122d8c.
  • Deleted the source branch.

Pipeline #3562585 passed

Pipeline passed for d8122d8c on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Gerhard Raven added 1 commit

    added 1 commit

    • c8275868 - Move computation of DOCA{,Chi2} related quantities from 'combinations' to...

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 5901c57a - Move computation of DOCA{,Chi2} related quantities from 'combinations' to...

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 6caf5bb5 - Move computation of DOCA{,Chi2} related quantities from 'combinations' to...

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 04507ea1 - Implement option to use any IDistanceCalculator tool in DistanceOfClosestApproach functor

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 24d1a345 - Implement option to use any IDistanceCalculator tool in DistanceOfClosestApproach functor

    Compare with previous version

  • Gerhard Raven added 2 commits

    added 2 commits

    • 4fc7df1c - Move computation of DOCA{,Chi2} related quantities from 'combinations' to...
    • f5dc297a - Implement option to use any IDistanceCalculator tool in DistanceOfClosestApproach functor

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 0af137fd - Require specification of 'fast' or 'suitable for long distances' computation in DOCA

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • b51eb23e - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 8775c3ee - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 4c0b4892 - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • ebfe9c69 - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • Gerhard Raven changed the description

    changed the description

  • Gerhard Raven added 1 commit

    added 1 commit

    • 1d0c5e78 - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 7a2aa21c - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • Edited by Software for LHCb
  • Gerhard Raven added 8 commits

    added 8 commits

    • 7a2aa21c...50f8d175 - 4 commits from branch master
    • 7c4afbf0 - Modify ParticleCombination to make the type independent of the number of particles
    • 3d76053b - Move computation of DOCA{,Chi2} related quantities from 'combinations' to...
    • b1b44c14 - Implement option to use any IDistanceCalculator tool in DistanceOfClosestApproach functor
    • a0fc7f67 - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 498bcdd9 - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 029191fc - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 3faa85d3 - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 41709c8e - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 5b9e4e7c - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 44f92d22 - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 38568e88 - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • 3e11cef1 - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • beb05d7d - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • Gerhard Raven added 1 commit

    added 1 commit

    • a0375faa - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • mentioned in commit Moore@abdf0719

  • Gerhard Raven mentioned in merge request Moore!1301 (merged)

    mentioned in merge request Moore!1301 (merged)

  • Gerhard Raven added 1 commit

    added 1 commit

    • 36315005 - DOCA uses 'fast' for everything, LLDOCA uses IDistanceCalculator for two...

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading