SUMCONE functor and WeightedRelTableAlg
To complete the transition from LoKi to ThOr syntax for the SUMCONE functor, cover the general point discussed on the issue #272 (closed).
Currently implemented:
-
ARGfunctor, for retrieving the first or second element to which it is applied on the base of the index value -
DETA,DPHIandDR2functors, which evaluate the respective quantities from each particle-particle combination. -
COMB_MASSfunctor, that combined mass of the candidate and the reference particle (see !2755 (closed)) - The functionalities required by !2815 (closed)
-
RPPVIPCHI2functor, checks the minimum impact parameter chi2 for candidate particle wrt the primary vertex of the reference particle -
SHARE_BPVfunctor, checks if candidate and reference particle are sharing the same primary vertex -
WeightedRelTableAlg, an algorithm that receives as input the range of reference particles and the range of candidates. It is configured through a functor that determines the relations between particles that have to be selected (through a boolean WEIGHT value). The algorithm returns a RelationWeighted2D table. -
SUMRANGEfunctor, which sums a given input functor over a range of particles (from the TO side of the table). -
SUMCONEis an instance toMAP_INPUT_TO_ARRAYwithRelationTable = LHCb::RelationWeighted2D<LHCb::Particle,LHCb::Particle, double>
Commented out atm the functor VTX_FIT_CHI2 (check the "good-quality" of the vertex-fit and to cut on its chi2), which throws an exception while trying to bind to the algorithm which is not Condition holder. Need to be investigated further: planning to come back on it later.
TESTS:
-
Rec 
-
Moore (Moore!1461 (closed)) -
DaVinci (DaVinci!665 (merged)) -> Implement it once merged
TODO:
-
Create a ThOr functor to replace DeltaR2() function, which accepts a range of particles and evaluates the dr2 for each possible combination; -
Configure the algorithm through external functors; -
Generalize the algorithm also for !2755 (closed), !2815 (closed) and other purposes... -
Test for track-like and composite particles
FYI: @mvesteri, @poluekt, @fpolci, @rmurta, @graven, @johndan, @roneil, @jugarcia
Merge request reports
Activity
added RTA label
- Resolved by Tommaso Fulghesu
mentioned in merge request DaVinci!665 (merged)
marked the checklist item Write a SUM_RANGE functor (see #272 (comment 5227977)) that sum the applied functor in a certain range (N.B: the subrange is at the moment delimited by the DeltaR2 predicate); as completed
added 1 commit
- 0a935e92 - Adjust phi angle inside [-180,180] range, still to solve casting issue
added 43 commits
-
abe7cb76...21a36716 - 40 commits from branch
master - d4ca46ec - Implementation of relation table
- 1ad9cc51 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into tfulghes-sumcone-isolation
- 1e9ecb5d - Implement Relation Table
Toggle commit list-
abe7cb76...21a36716 - 40 commits from branch
mentioned in merge request !2755 (closed)
- Resolved by Tommaso Fulghesu
added 27 commits
-
7c06aaa6...68b392cf - 24 commits from branch
master - af3efdba - Fix code, implement most of the logic, add comments
- a51f7e7c - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into tfulghes-sumcone-isolation
- 90f652ce - Merge branch 'tfulghes-sumcone-isolation' of...
Toggle commit list-
7c06aaa6...68b392cf - 24 commits from branch
added 8 commits
- d4333a1d - remove obsolete code
- 3051078e - minor generalisation
- 7eb66d77 - Fixed formatting
- 71fc60a0 - Make MuonId in Hlt2 functional
- 2aae0d05 - add Identity functor
- e4c2fb75 - Fixed formatting
- a94c09f6 - Merge branch 'tnanut_filterRelTab' of ssh://gitlab.cern.ch:7999/lhcb/Rec into...
- 871fb35b - Start testing: fixing pt.3 -> understand how to call the functor inside the loop
Toggle commit listadded 23 commits
-
871fb35b...9f3a94a5 - 19 commits from branch
master - c57c52c6 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into tfulghes-sumcone-isolation
- 67184817 - Try to implement functor in the algo
- 5fbffaac - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into tfulghes-sumcone-isolation
- 650e8b63 - Call the external functor from the algorithm
Toggle commit list-
871fb35b...9f3a94a5 - 19 commits from branch
added 2 commits
added 32 commits
-
d2d9d83f...62ed7507 - 28 commits from branch
master - d0107a56 - Add changes for support DeltaPhi, DeltaEta and DeltaR2 as functors
- adbfc614 - Rebase Rec
- 7e1e3c30 - Add changes to functors
- 3294540d - Simplify logic for the algorithm
Toggle commit list-
d2d9d83f...62ed7507 - 28 commits from branch
added 1 commit
- 47b69b4c - Use predicate for filtering table and fix definition of deltaR2
