Add test for Neutral functors and Remove IsNotE functor

Add test to TestFunctors.cpp. Template it to incorporate also the test for ProbNN functors.

It has been pointed out that IsNotE will not be updated for Run 3, as it's not possible to distinguish between photons and electrons with only Ecal information (without the SPD detector).

Additionally, explicitly add include for dependency.

added RTA label

changed the description

removed RTA label

added Functors RTA labels

marked this merge request as ready

Hi @tnanut according to the discussion in your previous MR, is there already a line or something we could test together with this MR?

Hi @peilian we plan to work on adding a dummy line next week

marked this merge request as draft

added 17 commits

• 77903fd6...68b392cf - 10 commits from branch master
• ea5ad77d - update NeutralLike.h
• a267b3e0 - back to only adding Function
• 4437015d - change return static assert
• f68da407 - remove IsNotE
• dca13fc9 - Test in Rec for neutral
• dc865c01 - template everything except filter
• 4befabaa - remove obsolete code

Compare with previous version

changed title from Draft: Remove IsNotE functor to Draft: Add test for Neutral functors and Remove IsNotE functor

changed the description

added 1 commit

• f571464b - Fixed formatting

Compare with previous version

added 3 commits

• 68c8ff20 - test templating filter
• 679ae4b5 - template it all
• e0603a5b - add the actual test

Compare with previous version

added 1 commit

• ef625416 - Fixed formatting

Compare with previous version

approved this merge request

added 24 commits

• ef625416...e7a0a19f - 11 commits from branch master
• a7b6c89f - update NeutralLike.h
• 0e132436 - back to only adding Function
• 2c720a0b - change return static assert
• c0e2eec6 - remove IsNotE
• a2a23ace - Test in Rec for neutral
• e28cf41c - template everything except filter
• 7ee670ff - remove obsolete code
• 14896f29 - Fixed formatting
• 3dd7cefd - test templating filter
• 36e620b3 - template it all
• b9ea3cda - add the actual test
• 5775b2fd - Fixed formatting
• bdb67b76 - remove neutral functors from exceptions test

Compare with previous version

changed the description

marked this merge request as ready

assigned to @msaur and @tnanut

mentioned in merge request Moore!1434 (merged)

changed the description

/ci-test

added ci-test-triggered label

• [2022-03-15 16:34] Validation started with lhcb-master-mr#3990

assigned to @rmatev

added 18 commits

• bdb67b76...b74f99ce - 17 commits from branch master
• e50b0403 - Add test for Neutral functors and Remove IsNotE functor

Compare with previous version

resolved all threads

merged

mentioned in commit 7f040c8e

mentioned in issue Moore#411 (closed)

added enhancement label

added cleanup label and removed enhancement label