Convert TrackFitMatchMonitor histos

Convert TrackFitMatchMonitor histograms to use thread safe histograms in line with #248

NB: Currently compiles but not tested yet

FYI @bimitres, @graven, @sponce

added cleanup label

changed title from WIP: Track fit match monitor histos to WIP: Convert TrackFitMatchMonitor histos

added 1 commit

• fb8bdeb9 - Fix deltac typos

Compare with previous version

changed the description

added RTA label

Looks pretty good. I made a couple of comments, the only important one being the usage of unique_ptr, which I do not really understand. Is there a good reason for it ?

closed

reopened

Sorry for the closing... wrong button...

added 1 commit

• c4ef1a0d - Remove commented out old code

Compare with previous version

added 1 commit

• d1d2212a - Use enum as keys instead of strings

Compare with previous version

added 1 commit

• bd61da98 - Change plotDelta and makePlots to use enum instead of string as arg [ci skip]

Compare with previous version

added 1 commit

• 4490ffe2 - Avoid using extra dictionary [ci skip]

Compare with previous version

added 1 commit

• 3cd4e11a - Add toString function to avoid using unordered_map [skip ci]

Compare with previous version

added 1 commit

• f9fc149a - Manual instantation of histograms to remove unordered_map

Compare with previous version

mentioned in issue #248

added 1 commit

• 012ca9b7 - correct quantites to be plotted

Compare with previous version

added 1 commit

• cafc5c81 - Fixed formatting

Compare with previous version

@graven I had compilation issues not using unique ptrs but I have now instantiated them by hand rather than a loop to remove the need of a dictionary. Other than that I have tested the histogram output and I think this is ready to be merged

marked this merge request as draft

marked this merge request as ready

changed title from WIP: Convert TrackFitMatchMonitor histos to Convert TrackFitMatchMonitor histos

Hi @jcobbled, is this ready to be tested?

assigned to @fsouzade

added ci-test-triggered label

• [2022-04-13 13:23] Validation started with lhcb-master-mr#4224

added needs ref update label

assigned to @rmatev

removed needs ref update label

added Monitoring label

approved this merge request

@jcobbled there are some conflicts with !2802 (merged) which I merged today. Could you please take a look?

mentioned in issue Moore#421 (closed)

assigned to @thboettc and unassigned @fsouzade