change name of MuonPIDConverter to follow naming scheme

change name of muonConverter to follow naming scheme

Requires: Moore!1678 (merged)

assigned to @rvazquez

added RTA label

mentioned in merge request Moore!1678 (merged)

mentioned in issue #368 (closed)

@rvazquez Is this ready to be tested or do you expect some further development.

changed the description

this is ready to be tested

resolved all threads

/ci-test Moore!1678 (merged)

added ci-test-triggered label

• [2022-07-19 18:16] Validation started with lhcb-master-mr#5119

added 1 commit

• a66ecaf3 - apply suggestions

Compare with previous version

added 1 commit

• e9b46b91 - remove file

Compare with previous version

added 1 commit

• 1cd98c71 - Fixed formatting

Compare with previous version

I have implemented the requested changes. When putting the namespace has uncovered I have changed the name of the new MuonPID otherwise new and old had the same name. This is ready to test and review.

approved this merge request

added 1 commit

• 2dedfa3c - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 18 commits

• 2dedfa3c...2e039bd7 - 13 commits from branch master
• 34840742 - change name of muonConverter to follow naming scheme
• 1e9c7751 - apply suggestions
• 3ae48896 - remove file
• 561f539f - Fixed formatting
• ea986de0 - remove using and change transformer from Gaudi::functional to LHCb::Algorithm

Compare with previous version

I see the copyright and formating checks failing, but I get any automatic message. I think I did a push while there was an update in gitlab. Relaunching the tests still fail with a message I have never seen. Is this a hiccups from the downtime? Because I see the copyright in the files.

Running with gitlab-runner 15.0.0 (febb2a09) on default-runner-6b84cffc56-6468d 4zM9zKPr feature flags: FF_DISABLE_UMASK_FOR_DOCKER_EXECUTOR:true Resolving secrets 00:00 Preparing the "docker" executor 00:01 Using Docker executor with image gitlab-registry.cern.ch/ci-tools/ci-worker:cc7 ... Authenticating with credentials from job payload (GitLab Registry) Pulling docker image gitlab-registry.cern.ch/ci-tools/ci-worker:cc7 ... WARNING: Failed to pull image with policy "always": Error response from daemon: manifest for gitlab-registry.cern.ch/ci-tools/ci-worker:cc7 not found: manifest unknown: manifest unknown (manager.go:203:0s) ERROR: Job failed: failed to pull image "gitlab-registry.cern.ch/ci-tools/ci-worker:cc7" with specified policies [always]: Error response from daemon: manifest for gitlab-registry.cern.ch/ci-tools/ci-worker:cc7 not found: manifest unknown: manifest unknown (manager.go:203:0s)

added 1 commit

• 26028307 - Fixed formatting

Compare with previous version

/ci-test Moore!1678 (merged)

• [2022-07-21 10:00] Validation started with lhcb-master-mr#5135
• [2022-07-21 18:15] Validation started with lhcb-master-mr#5146
• [2022-07-22 13:05] Validation started with lhcb-master-mr#5160

added 52 commits

• 26028307...5c879d5c - 45 commits from branch master
• 88a6914a - change name of muonConverter to follow naming scheme
• e3361d41 - apply suggestions
• f6b2e3d8 - Fixed formatting
• aad10727 - remove using and change transformer from Gaudi::functional to LHCb::Algorithm
• b8b08e4d - Fixed formatting
• ead83263 - remove file
• 0f23b23c - fix conflicts

Compare with previous version

added 1 commit

• e85ee71a - Fixed formatting

Compare with previous version

added hlt2-throughput-decreased label

added hlt1-throughput-increased label

removed hlt2-throughput-decreased label

removed hlt1-throughput-increased label

mentioned in issue Moore#456 (closed)

added 32 commits

• e85ee71a...19f066cb - 24 commits from branch master
• 9f7dd8d8 - change name of muonConverter to follow naming scheme
• 82c58d53 - apply suggestions
• f574e74b - Fixed formatting
• 3ea2eb04 - remove using and change transformer from Gaudi::functional to LHCb::Algorithm
• 9d23beb5 - Fixed formatting
• 1c2b1238 - remove file
• 72e28130 - fix conflicts
• 8a7002ad - Fixed formatting

Compare with previous version

added 1 commit

• aec9a47f - update configuration with name change

Compare with previous version

• [2022-07-28 11:11] Validation started with lhcb-master-mr#5245

added needs ref update label

assigned to @rmatev

resolved all threads

The RefBot pipeline failed!

mentioned in commit Moore@5dc8d370

The RefBot pipeline created the following reference update MRs: Moore!1701 (merged), Alignment!300 (merged)

Click this to see encountered Alignment warnings

Alignment/x86_64_v2-centos7-clang12-opt: Test Humboldt.iterator-vp-halves-modules contains nonzero exit code and/or warnings!
Alignment/x86_64_v2-centos7-clang12-opt: Test without ref failed: Humboldt.iterator-vp-halves-modules!

Click this to see encountered Allen warnings

Allen: Mixed statuses of 'passed' and 'failed' found. Update of Rec/Allen/tests/refs/allen_event_loop.ref not possible.

Click this to see encountered Moore warnings

Moore/x86_64_v2-centos7-gcc11-opt: Test Hlt2Conf.monitoring.test_hlt2_default_monitoring was not run because of failed dependencies and is possibly missing a reference update!
Moore/x86_64_v2-centos7-gcc11-opt: Test RecoConf.hlt2_reco_baseline_multi_threaded was not run because of failed dependencies and is possibly missing a reference update!
Moore/x86_64_v2-centos7-gcc11-dbg: Test Hlt2Conf.monitoring.test_hlt2_default_monitoring was not run because of failed dependencies and is possibly missing a reference update!
Moore/x86_64_v2-centos7-gcc11-dbg: Test RecoConf.hlt2_reco_baseline_multi_threaded was not run because of failed dependencies and is possibly missing a reference update!
Moore/x86_64_v2-centos7-clang12-opt: Test Hlt2Conf.monitoring.test_hlt2_default_monitoring was not run because of failed dependencies and is possibly missing a reference update!
Moore/x86_64_v2-centos7-clang12-opt: Test RecoConf.hlt2_reco_baseline_multi_threaded was not run because of failed dependencies and is possibly missing a reference update!
Moore/x86_64_v3-centos7-gcc11-opt+g: Test Hlt2Conf.monitoring.test_hlt2_default_monitoring was not run because of failed dependencies and is possibly missing a reference update!
Moore/x86_64_v3-centos7-gcc11-opt+g: Test RecoConf.hlt2_reco_baseline_multi_threaded was not run because of failed dependencies and is possibly missing a reference update!
Moore: Warning, results for test: RecoConf.hlt2_protoparticles_baseline not found for platforms: {'x86_64_v2-centos7-clang12-opt', 'x86_64_v2-centos7-gcc11-dbg'}
Moore: Warning, results for test: RecoConf.hlt2_protoparticles_fastest not found for platforms: {'x86_64_v2-centos7-clang12-opt', 'x86_64_v2-centos7-gcc11-dbg'}

Click this to see encountered MooreOnline warnings

MooreOnline/x86_64_v3-centos7-gcc11-opt+g: Test AllenOnline.check_duplicates was not run because of failed dependencies and is possibly missing a reference update!
MooreOnline/x86_64_v3-centos7-gcc11-opt+g: Test AllenOnline.decode_allen_output was not run because of failed dependencies and is possibly missing a reference update!
MooreOnline/x86_64_v3-centos7-gcc11-opt+g: Test AllenOnline.test_mep_banks was not run because of failed dependencies and is possibly missing a reference update!
MooreOnline/x86_64_v3-centos7-gcc11-opt+g: Test AllenOnline.test_mep_banks_transpose was not run because of failed dependencies and is possibly missing a reference update!
MooreOnline: Mixed statuses of 'passed' and 'failed' found. Update of AllenOnline/tests/refs/mep_passthrough.ref not possible.
MooreOnline: Warning, results for test: AllenOnline.test_mep_banks not found for platforms: {'x86_64_v3-centos7-gcc11-opt+g'}
MooreOnline: Warning, results for test: AllenOnline.test_mep_banks_transpose not found for platforms: {'x86_64_v3-centos7-gcc11-opt+g'}
MooreOnline: Warning, results for test: AllenOnline.decode_allen_output not found for platforms: {'x86_64_v3-centos7-gcc11-opt+g'}

mentioned in commit Alignment@acd77435

mentioned in merge request Alignment!300 (merged)

mentioned in merge request Moore!1701 (merged)

added Muon PID cleanup labels