Use PV unbiasing and small cleanup of aliases

Use of the PV unbiasing that's implemented in LHCb!3716 (merged) . Aliases for 2 classes were put into ITaggingHelperTool.h. I removed those and replaced them everywhere with the fully written out classes.

@dtou @zhshen

Test together with LHCb!3716 (merged)

Phys/FunctionalFlavourTagging/src/Utils/ITaggingHelperTool.h

@@ -8,8 +8,7 @@
 * granted to it by virtue of its status as an Intergovernmental Organization  *
 * or submit itself to any jurisdiction.                                       *
 \*****************************************************************************/
-#ifndef PHYS_PHYS_FLAVOURTAGGING_ITAGGINGHELPERTOOL_H
-#define PHYS_PHYS_FLAVOURTAGGING_ITAGGINGHELPERTOOL_H 1
+#pragma once
 
 #include "GaudiKernel/IAlgTool.h"
 
@@ -21,9 +20,6 @@
 // from FunctionalFlavourTagging
 #include "TaggingHelper.h"
 
-using PrimaryVertices                 = LHCb::Event::PV::PrimaryVertexContainer;
-using PrimaryVertexConstPointerVector = boost::container::small_vector<const LHCb::VertexBase*, 16>;
-
 class ITaggingHelperTool : virtual public IAlgTool {
 
   DeclareInterfaceID( ITaggingHelperTool, 3, 0 );
@@ -34,23 +30,18 @@ public:
   virtual std::optional<std::pair<double, double>> calcIPWithChi2( const LHCb::Particle&, const LHCb::VertexBase&,
                                                                    const IGeometryInfo& ) const = 0;
   virtual std::optional<std::pair<double, double>>
-  calcMinIPWithErr( const LHCb::Particle&, const PrimaryVertexConstPointerVector&, const IGeometryInfo& ) const = 0;
+  calcMinIPWithErr( const LHCb::Particle&, LHCb::span<LHCb::VertexBase const* const>, const IGeometryInfo& ) const = 0;
   virtual std::optional<std::pair<double, double>>
-  calcMinIPWithChi2( const LHCb::Particle&, const PrimaryVertexConstPointerVector&, const IGeometryInfo& ) const = 0;
+  calcMinIPWithChi2( const LHCb::Particle&, LHCb::span<LHCb::VertexBase const* const>, const IGeometryInfo& ) const = 0;
 
   virtual bool hasOverlap( const LHCb::Particle&, const LHCb::Particle& ) const = 0;
 
-  virtual const LHCb::VertexBase* bestPV( const LHCb::Particle&, const PrimaryVertices& ) const = 0;
-
   virtual std::optional<LHCb::Vertex> fitVertex( const LHCb::Particle&, const LHCb::Particle&,
                                                  const IGeometryInfo& ) const = 0;
 
-  virtual std::optional<const LHCb::VertexBase> refitPVWithoutB( const LHCb::VertexBase&, const LHCb::Particle&,
-                                                                 const IGeometryInfo& ) const                    = 0;
   virtual TaggingHelper::CloneStatus cloneCategory( const LHCb::Particle&, const LHCb::Particle&, double ) const = 0;
 
   virtual bool passesCommonPreSelection( const LHCb::Particle&, const LHCb::Particle&,
-                                         const PrimaryVertexConstPointerVector&, const IGeometryInfo& ) const = 0;
+                                         const LHCb::span<LHCb::VertexBase const* const>,
+                                         const IGeometryInfo& ) const = 0;
 };
-
-#endif // PHYS_PHYS_FLAVOURTAGGING_ITAGGINGHELPERTOOL_H