New DecayFinder for Run 3
This MR contains a new templated DecayFinder.
TODO:
-
Preliminary design of the DecayFinder for V1 Particles. It contains: - Class
Decay::Node - Class
Decay::Arrow - Class
Decay::Tree - Class
Decay::DecayFinder - Interface
IDecayFinder.
- Class
-
Convert tests from main.cppinto set ofpytest. -
Introduce dependency of FunTuple on finder. (Analysis!916 (merged)).
Adapt methods for V2 Particles: This will be a follow-up MR issue (#398)
To be tested with: Analysis!916 (merged)
Merge request reports
Activity
added DPA-WP3 Event model Tuples labels
added RTA label
requested review from @pkoppenb
-
Wow. That's a lot of code. Congratulations on the project. You've seen the comment on doxygen. Now it's broken but I hope it may come back one day, so please think about which comments should appear as documentation.
You already have a test python file. Please make that into a qmtest before moving to the next step. I would suggest that once there is a test this can be tested and merged, then leave the v2 stage for another MR.
Resolved by Abhijit MathadIndeed great to see this
Tiny question: why not leave tests as simple as possible? Personally I'm not a fan of QMTests and will always go for simple pytest style of tests when possible/suitable :-). Here the various bits of functionality do look adequate for several scoped tests IMO.
It does not mean that we will not want some more complete example with a QMTest for it ...
No strong feeling anyway. More personal taste.
- Last reply by Abhijit Mathad
- Resolved by Abhijit Mathad
General comment: I see you have at least an interface and then the actual Gaudi tool. Why not go functional from the onset? This is anyway a requirement as we eventually want the whole DaVinci/Moore multi-threaded. It would also make the code nicer and modern.
- Last reply by Abhijit Mathad
added 4 commits
-
1a873d88...8a60838c - 2 commits from branch
master - c1063a9e - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_DecayFinder
- bee6d093 - move to ptr of ptr
-
1a873d88...8a60838c - 2 commits from branch
added 9 commits
-
1dc7628d...84575fd4 - 6 commits from branch
master - 5713bd1e - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_DecayFinder
- ee06c604 - fix iterative finding
- 127c952f - convert more Sachas tests to pytest
Toggle commit list-
1dc7628d...84575fd4 - 6 commits from branch
added 9 commits
-
127c952f...d626d478 - 8 commits from branch
master - fd750ef8 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_DecayFinder
-
127c952f...d626d478 - 8 commits from branch
added 5 commits
-
8e34660d...6c9ed460 - 4 commits from branch
master - 23d8c63c - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_DecayFinder
-
8e34660d...6c9ed460 - 4 commits from branch
marked the checklist item Convert tests from
main.cppinto unit tests as completedadded 5 commits
-
b8f5ef58...2cbd8498 - 4 commits from branch
master - 832cd237 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_DecayFinder
-
b8f5ef58...2cbd8498 - 4 commits from branch
mentioned in merge request Analysis!916 (merged)
marked the checklist item Introduce dependency of FunTuple on finder. (Analysis!916 (merged)). as completed
mentioned in issue #397 (moved)