Add new algorithm and a functor for storing Hlt1 TIS/TOS information

The MR adds the following:

• Add Hlt1TisTos algorithm (based on the old tool IParicleTisTos)
• Two new functors:
  • F.VALUE: Functor to get a value from std::optional, if it encounters std::nullopt it throws a GaudiException.
  • F.MAP_TO_RELATED: Functor to store TIS/TOS information of user-specified Hlt1 lines using relations table.
• Changes the functor grammer so that one can pass a dict to F.VALUE_OR(<dict>).
• We also add tests for both F.VALUE and F.VALUE_OR(<dict>).

This MR only addresses Hlt1 Tis/Tos information. The Hlt2 Tis/TOS needs to be separate MR

Relates to https://gitlab.cern.ch/lhcb-dpa/project/-/issues/142.

To be tested with: LHCb!3845 (merged) DaVinci!771 (merged) Analysis!935 (merged)

FYI: @erodrigu , @pkoppenb , @yingl , @emarinov

added DPA-WP3 Functors labels

requested review from @sstahl and @graven

assigned to @amathad

added RTA label

changed the description

removed RTA label

marked this merge request as draft

added RTA label

Very nice to see this @amathad

What is the motivation for storing a dedicated TOB value? TOB is equivalent to (NOT TIS AND NOT TOS) so this doesn't add extra information.

How would one use the functor in a trigger line? E.g. the Topo will probably cut on something like the TOS of Hlt1(Two)?TrackMVA.*Decision. Would there be another functor which looks this up in the output map of the functor implemented here?

Thanks for the MR @amathad .

Need to correctly set the location of Hlt1 DecReport and SelReport (@nskidmor input is needed here).

The locations seem hard coded. Do we guarantee stability of the locations? In the end these are locations which should come out of a decoder which is functional and can be configured via PyConf.

Hlt2 Tis/TOS (@graven : Should this be a separate MR?)

I think HLT2 TisTos can be a separate MR.

Need to add test in DaVinci (Hope @oozcelik can help me here). Not sure how to go about adding test in Rec.

See other questions, what about using the functor in lines? There we also need to be able to use TISTOS. Should this be done via functors or via a dedicated algorithm?

added 1 commit

• 1d8594a3 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 16 commits

• 1d8594a3...44cbb4a0 - 10 commits from branch master
• ef6cd255 - add Hlt1TisTos functor
• bed7664a - small fix
• 2456672e - add new tistos algorithm
• 42b52b0d - revert previous changes
• 65a2feb5 - add functor and algorithm
• 45320274 - Merge branch 'AM_Hlt1TisTos' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_Hlt1TisTos

Compare with previous version

added 3 commits

• 375e3643 - add Hlt1TisTos functor
• b3d729ab - Apply 1 suggestion(s) to 1 file(s)
• afed550e - Merge branch 'AM_Hlt1TisTos' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_Hlt1TisTos

Compare with previous version

changed title from Draft: Add new functor for storing Hlt1 TIS/TOS/TOB information to Draft: Add new algorithm and a functor for storing Hlt1 TIS/TOS information

changed the description

added 1 commit

• de25e091 - remove previous changes

Compare with previous version

added 2 commits

• 274c7d2b - remove previous changes
• ef30e8e4 - Merge branch 'AM_Hlt1TisTos' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_Hlt1TisTos

Compare with previous version

added 3 commits

• ef30e8e4...cfff4e5f - 2 commits from branch master
• f391eed9 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_Hlt1TisTos

Compare with previous version

resolved all threads

added 1 commit

• 86159b02 - fix small thing with doc

Compare with previous version

added 36 commits

• 86159b02...ccb7d843 - 35 commits from branch master
• 57689cab - Merge branch 'master' into AM_Hlt1TisTos

Compare with previous version

added 1 commit

• fe746ffa - rename alg

Compare with previous version

added 1 commit

• 165bfbeb - add dict to VALUE_OR

Compare with previous version

mentioned in merge request DaVinci!771 (merged)

added 1 commit

• 574a0001 - add decreports

Compare with previous version

added 1 commit

• e3dc7aa6 - fix formatting

Compare with previous version

added 17 commits

• e3dc7aa6...0701afec - 16 commits from branch master
• 654c8049 - Merge branch 'master' into AM_Hlt1TisTos

Compare with previous version

added 1 commit

• 9778cd22 - fix compilation

Compare with previous version

added 5 commits

• 9778cd22...8c07079b - 4 commits from branch master
• 0867cfd3 - Merge branch 'master' into AM_Hlt1TisTos

Compare with previous version

added 8 commits

• 0867cfd3...ae56c9be - 4 commits from branch master
• 0f4d5bfa - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_Hlt1TisTos
• 9fbe7adf - add a test to check if dict work with VALUEOR
• d7a0934d - modify the grammer so that dict works with VALUEOR
• ffba0c51 - add improvements to HltTisTosAlg

Compare with previous version

added 1 commit

• acfcb30f - small modification from bool to int

Compare with previous version

added 28 commits

• acfcb30f...be097994 - 27 commits from branch master
• 67147a3d - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_Hlt1TisTos

Compare with previous version

added 3 commits

• a978330b - small fix
• 2c000876 - debug messages
• d8b900a4 - fix debug

Compare with previous version

added 1 commit

• 14ebe61c - Fixed formatting

Compare with previous version

changed the description

resolved all threads

added 21 commits

• 14ebe61c...c8557a36 - 19 commits from branch master
• 0dc94e7c - Merge branch 'master' into AM_Hlt1TisTos
• 1caa712c - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_Hlt1TisTos

Compare with previous version

added 1 commit

• 9a9c0615 - add a new functor and update tests and TisTos

Compare with previous version

added 1 commit

• 64b33f17 - Fixed formatting

Compare with previous version

mentioned in merge request LHCb!3845 (merged)

changed the description

added 1 commit

• fdf11aac - change the invalid value to zero instead of -1

Compare with previous version

added 4 commits

• fdf11aac...b39789a6 - 3 commits from branch master
• 3dcc6020 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_Hlt1TisTos

Compare with previous version

mentioned in issue #424 (closed)

added 15 commits

• 3dcc6020...c57b0556 - 14 commits from branch master
• 84325f25 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_Hlt1TisTos

Compare with previous version

added 101 commits

• 84325f25...81c19fd3 - 100 commits from branch master
• c8e803aa - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_Hlt1TisTos

Compare with previous version

mentioned in merge request Analysis!935 (merged)

changed the description

added 63 commits

• c8e803aa...b84746ff - 62 commits from branch master
• 0db8d677 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_Hlt1TisTos

Compare with previous version

marked this merge request as ready

assigned to @mramospe

the MR is ready to test, can you please @mramospe ?

added ci-test-triggered label

• [2022-11-30 18:44] Validation started with lhcb-master-mr#6458
• [2022-12-01 20:34] Validation started with lhcb-master-mr#6474
• [2022-12-07 19:04] Validation started with lhcb-master-mr#6529

mentioned in merge request !3219 (merged)

added hlt2-throughput-decreased label

added 6 commits

• 0db8d677...390a733a - 4 commits from branch master
• f13db6ee - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_Hlt1TisTos
• 6bb54106 - make MVA grammer a special case

Compare with previous version

added 14 commits

• 6bb54106...d4ad23af - 13 commits from branch master
• 303ff97b - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_Hlt1TisTos

Compare with previous version

added 1 commit

• 4b667f39 - Fixed formatting

Compare with previous version

added 1 commit

• 848d4051 - fix nan

Compare with previous version

/ci-test --platforms=x86_64_v2-centos7-gcc11-opt LHCb!3845 (merged) DaVinci!771 (merged) Analysis!935 (merged)

added 19 commits

• 848d4051...ae2079eb - 16 commits from branch master
• 31de01e8 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_Hlt1TisTos
• cd272412 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_Hlt1TisTos
• 916d520d - fix conflict

Compare with previous version

/ci-test --platforms=x86_64_v2-centos7-gcc11-opt LHCb!3845 (merged) DaVinci!771 (merged) Analysis!935 (merged)

resolved all threads

• [2022-12-07 23:17] Validation started with lhcb-master-mr#6530
• [2022-12-08 12:05] Validation started with lhcb-master-mr#6531

/ci-test LHCb!3845 (merged) DaVinci!771 (merged) Analysis!935 (merged)

resolved all threads

removed hlt2-throughput-decreased label

assigned to @axu and unassigned @mramospe

mentioned in issue Moore#506 (closed)

unassigned @axu

added 72 commits

• 916d520d...d6eede62 - 71 commits from branch master
• 52184f9e - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Rec into AM_Hlt1TisTos

Compare with previous version

resolved all threads

/ci-test LHCb!3845 (merged) DaVinci!771 (merged) Analysis!935 (merged)

• [2023-01-09 14:00] Validation started with lhcb-master-mr#6680

mentioned in merge request Moore!1987 (closed)

changed the description

changed the description

assigned to @sponce

/ci-test LHCb!3845 (merged) DaVinci!771 (merged) Analysis!935 (merged)

resolved all threads