Skip to content
Snippets Groups Projects

New PID Substitution DaVinci Tool

Merged Jiahui Zhuo requested to merge jzhuo_SubsPID into master

Start from #305 (closed), implementing the comment #305 (comment 5363235).

This MR will add a new PID substitution Tool and a new DTF Tool for DaVinci, which has integrated the PID substitution. A minimal example of the usage could be:

DTF_KstG = DecayTreeFitter(
    Name = 'DTF_KstG',
    Input = B_Data,
    Substitutions = [
        ' B0 ->  ( K*(892)0 ->  K+ K-{{pi-}} ) gamma',
    ]
)
variables_all = FC({
    # Original particle
    'ORIGINAL_ID'      : F.PARTICLE_ID,
    'ORIGINAL_ENERGY'  : F.ENERGY,
    'ORIGINAL_CHI2DOF' : F.CHI2DOF,
    # DTF Bd2KstGamma
    'DTF_KSTG_ID'      : F.VALUE_OR(-1) @ DTF_KstG.get_info( F.PARTICLE_ID ),
    'DTF_KSTG_ENERGY'  : DTF_KstG.get_info( F.ENERGY      ),
    'DTF_KSTG_CHI2DOF' : DTF_KstG.get_info( F.CHI2DOF     ),
})

A real example could be found in https://gitlab.cern.ch/lhcb/DaVinci/-/blob/jzhuo_SubsPID/DaVinciExamples/python/DaVinciExamples/tupling/option_davinci_tupling_DTF_substitutePID.py

Other example for SubstitutePID without DTF could be found in https://gitlab.cern.ch/lhcb/DaVinci/-/blob/jzhuo_SubsPID/DaVinciExamples/python/DaVinciExamples/tupling/option_davinci_tupling_substitutePID.py

This MR should be test with DaVinci!756 (merged)

FYI: @amathad @pkoppenb @erodrigu @fevolle

Closes #305 (closed) Closes #309 (closed)

Edited by Patrick Koppenburg

Merge request reports

Merge request pipeline #4755237 passed

Merge request pipeline passed for d4d8848c

Approved by

Merged by Sebastien PonceSebastien Ponce 2 years ago (Nov 16, 2022 6:01am UTC)

Merge details

Pipeline #4766938 passed

Pipeline passed for 51fed34d on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Patrick Koppenburg
  • Jiahui Zhuo added 3 commits

    added 3 commits

    • ca4276e4 - Adding the new syntax support and documentation
    • 3aae4615 - Documentation and code cleanup
    • bbc28b51 - More documentation and verbose

    Compare with previous version

  • Jiahui Zhuo resolved all threads

    resolved all threads

  • Jiahui Zhuo added 1 commit

    added 1 commit

    Compare with previous version

  • Jiahui Zhuo added 1 commit

    added 1 commit

    Compare with previous version

  • Jiahui Zhuo changed the description

    changed the description

  • what's the status here?

  • Author Developer

    Hi, yes, I just back this week. I will update the DaVinci/Example today and move this MR asap.

  • Patrick Koppenburg changed the description

    changed the description

  • Abhijit Mathad
  • Abhijit Mathad
  • Abhijit Mathad
  • Abhijit Mathad
  • Abhijit Mathad
  • Jiahui Zhuo added 1 commit

    added 1 commit

    • f472902c - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Jiahui Zhuo added 1 commit

    added 1 commit

    • a215d6ef - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Jiahui Zhuo added 1 commit

    added 1 commit

    • 3d42ab44 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • @jzhuo Are we ready for a new round of test ? I see one comment not yet answered.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading