Adapt MuonID to use DD4HEP

goes with LHCb!3800 (closed) and Detector!199 (merged)

mentioned in issue #407 (closed)

changed the description

added RTA label

added Muon label

added lhcb-dd4hep label

changed title from adapt to use DD4HEP to Adapt MuonID to use DD4HEP

mentioned in merge request Detector!199 (merged)

mentioned in merge request Moore!1788 (merged)

thanks. ci test started here Moore!1788 (comment 6055762)

added dd4hep label

added PID label

• [2022-10-03 15:54] Validation started with lhcb-master-mr#5822

@rvazquez Just for my own info whats the actual fix here ? It looks like you have just reordered the headers here and in LHCb!3800 (closed) so on the face of it I am not sure I see how it fixes anything ?

b.t.w. you should run the Moore tests in the dd4hep build with Moore!1788 (merged) as that adds a couple of new tests that expose the reco issue.

ahh, this I didn't know. I was also surprised about how easy was to fix this

Reordering the headers really shouldn’t have any impact. The fact it seems to cause a build failure is actually a bit concerning in itself..

The best way to reproduce the issue, with all the MRs needed to get there is to use the lhcb-dd4hep builds. These have a number of not yet merged MRs applied, for instance the Moore MR that adds the test that exposes the Muon issue

https://lhcb-nightlies.web.cern.ch/nightly/lhcb-dd4hep/1287/Moore/x86_64_v2-centos7-gcc11+dd4hep-dbg/tests#RecoConf.hlt2_light_reco_pr_kf_without_UT_Calo

The above test shows the seg. fault we are looking to fix.

Note the Detector MR is now merged, so as long as you use the MR Moore!1703 (merged) to update the MC samples used to a recent one, the issue can be reproduced with the master builds.

@rvazquez I am afraid but it looks like the changes here do not build in the dd4hep builds. See e.g.

https://lhcb-nightlies.web.cern.ch/nightly/lhcb-master-mr/5822/Rec/x86_64_v2-centos7-gcc11+dd4hep-opt/build

./Muon/MuonID/src/component/MuonIDHltAlg.cpp:500:49: error: 'boost::container::static_vector<MuonIDHltAlg<LHCb::Event::v3::Tracks>::chi2CorrAndTileIDs(float, const MuonTrackExtrapolation&, const MuonHitContainer&, const MuonTrackOccupancies&, const details::Cache&) const::MuonHit, 4, void> cand' has incomplete type
  500 |     boost::container::static_vector<MuonHit, 4> cand;
      |                                                 ^~~~

can you take a look please.

removed lhcb-dd4hep label

I've removed from the lhcb-dd4hep slot. Can be added back once the dd4hep issues are actually addressed.

mentioned in merge request LHCb!3800 (closed)

mentioned in issue Moore#482 (closed)

assigned to @rvazquez

closing as changes here are not the answer.

closed

mentioned in issue Moore#485 (closed)

mentioned in issue Moore#487 (closed)