Skip to content

WIP: Refactor PrForward and PrHybridSeeding to allow flagging of hits based on const input hits by using ModPrHit and to be reentrant.

Roel Aaij requested to merge raaij-const-pr-hits into future

Rather large merge request based on work by @tnikodem @rquaglia and @ldufour. Basic idea is to refactor PrForward and PrHybridSeeding to allow const PrHits as input and be reentrant/thread-safe

Several large changes

  • PrFTHitHandler becomes templated on the internal hit type to allow both PrHit (for PrForward) and ModPrHit (for PrHybridSeeding)
    • Use IndexedHitContainer1D inside PrFTHitHandler
    • Allow const access to some internals to be able to create PrFTHitHandler from PrHitHandler with minimal overhead.
  • Refactor PrForward to be reentrant by removing data-members that were used for intermediate storage in favour of passing function arguments.
  • Refactor PrHybridSeeding to use ModPrHit everywhere.

Several small unrelated changes

  • Trailing whitespace in a few places
  • Make const number constexpr to make gcc 6.2 happy
  • Make a method of TrackBestTrackCreator const that should be const

Merge request reports