Skip to content
Snippets Groups Projects

Remove HighPtJets, ClearDaughters and RelatedInfoTools

Merged Patrick Koppenburg requested to merge pkoppenb-RM into master
1 unresolved thread

One more step toward #358

Merge request reports

Merge request pipeline #5835430 passed

Merge request pipeline passed for 58351cb6

Approval is optional

Merged by Rosen MatevRosen Matev 1 year ago (Jul 14, 2023 8:56pm UTC)

Merge details

  • Changes merged into master with c036841d.
  • Deleted the source branch.

Pipeline #5898406 passed

Pipeline passed for c036841d on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
1 1 /***************************************************************************** \
  • Hi @pkoppenb, I just realized that this MR that got merge affects this file where there are defined some algorithms adopted for Run 3 software. Should it be the case? The algorithm SelectionFromWeightedRelationTable was introduced by !3434 (merged) to get a selection of particle that is a persistable object.

  • Hi @tfulghes . Oh that must have been an unintentional effect of a conflict resolution. Apologies. Can you please re-add it in a new MR? And also make sure there is a test of this algorithm somewhere. If this MR got merged it must have been that no test broke.

  • It was tested in some HLT2 lines with Moore!2370 (merged). With the last commit it was reverted back to the previous version, however it was a workaround necessary to solve the problem pointed in this thread here: Moore!2207 (comment 6749361). Should I recreate MR reverting the last changes?

  • Please register or sign in to reply
  • mentioned in commit Moore@8c4885d6

  • mentioned in commit Moore@8710bf45

  • mentioned in issue Moore#623 (closed)

  • mentioned in commit Moore@e85f1122

  • Please register or sign in to reply
    Loading