Skip to content
Snippets Groups Projects

Fix use of references to DD4hep handles

Merged Marco Clemencic requested to merge fix-use-of-ref-to-handle into master
All threads resolved!

In DD4hep mode the DeXyz detector types are handles (kind of smart pointers) and they are usually temporary instances, so they should not be kept by reference, but copied otherwise one will get segfaults (like in Detector!368 (comment 6769177)). In DetDesc, instead, one should keep references to the DeXyz instances, that's why I added a helper with LHCb!3596 (merged), which I used here to fix the implementation of a few ToolBinder specializations.

/cc @graven @sponce

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sebastien Ponce resolved all threads

    resolved all threads

  • Sebastien Ponce approved this merge request

    approved this merge request

  • Sebastien Ponce mentioned in commit 266c31d3

    mentioned in commit 266c31d3

  • Please register or sign in to reply
    Loading