add support for v6 UT data

depends on LHCb!4168 (merged)

FYI: @wokrupa, @tskwarni, @sponce

Hi Gerhard. I've debugging it right now. It looks like it is what we need. v5 working with simulation. v6. working with data. I would add some additional changes, however, maybe it would be better to do it in another MR?

added RTA label

resolved all threads

Ok, it's fine from our site. We can marge it.

approved this merge request

I am not happy with introduction of be UTDAQ::version::v6=5 on the decoder side, to decode the real UT Tell40 data, which was actually written with UTDAQ::version::v2=1. I realize that it was a screw up to set the low bank version when taking the data, but to me diverging a decoder versioning to what is in the RawBank->version() is even worse. Thus I would prefer, if what we have been calling UTDecoderUTDAQ::version::v6, was actually UTDecoderUTDAQ::version::v2.

The future real UT Tell40 data should be taken with UTDAQ::version::v5=4 in RawBank->version(), which has been in use for a while in MC.

If other people agree with me, could we please make this change before we merge?

unapproved this merge request

mentioned in merge request LHCb!4168 (merged)

added 1 commit

• 3f8dd6b6 - fixing ut versioning issue

Compare with previous version

we sorted out that the v6 decoder should be in fact v2 to match the UT Bank version in early data from the UT (1). After the byte swapping in firmware, the v5 decoder will decode both the simulated and data sample (the bank version will be changed to match the decoder in v5 (4)). It's not an ideal solution, but it does not require the introduction of a new version of the decoder only for early data.

approved this merge request

mentioned in issue Moore#598 (closed)

mentioned in issue Moore#599 (closed)

assigned to @bkhanji and @wokrupa

mentioned in issue Moore#623 (closed)

assigned to @jonrob

added ci-test-triggered label

• [2023-07-25 14:48] Validation started with lhcb-master-mr#8645
• [2023-07-25 15:57] Validation started with lhcb-master-mr#8651
• [2023-08-21 15:05] Validation started with lhcb-master-mr#8973
• [2023-09-04 14:24] Validation started with lhcb-master-mr#9127

/ci-test LHCb!4168 (merged)

added hlt2-throughput-increased label

mentioned in issue Moore#627 (closed)

mentioned in issue Moore#634 (closed)

unassigned @jonrob

removed hlt2-throughput-increased label

mentioned in issue Moore#652 (closed)

added Tracking UT enhancement labels

resolved all threads

assigned to @rmatev

merged

mentioned in commit 0758f95d

mentioned in issue Moore#659 (closed)