Add functors to retrieve LHC conditions

GOES WITH Detector!418 (merged), DaVinci!1017 (merged) LHCb!4517 (merged)

Second step towards #497 (closed)

Add the following functors to retrieve LHC condition information from parent algorithm:

• CONDITION: general functor to access to condition derivation from DeLHCb
• LHC_INFO: set of LHC condition from yaml files in https://gitlab.cern.ch/lhcb-conddb/lhcb-conditions-database/-/blob/master/Conditions/LHCb/Online/LHC.yml
• FILL_NUMBER, LHC_ENERGY, LHCB_CLOCKPHASE: LHC conditions derived

TODO:

• Fix CONDITION functor
• Add tests on DaVinci

FYI: @mvesteri, @poluekt, @raaij, @mfontana, @cmarinbe

added Functors ThOr labels

assigned to @tfulghes

added RTA label

changed the description

mentioned in merge request LHCb!4226 (closed)

mentioned in merge request Detector!418 (merged)

changed the description

@tfulghes This needs both rebasing and fix formatting.

mentioned in issue Moore#652 (closed)

added 277 commits

• 24e6b7ef...ea961286 - 272 commits from branch master
• c59e8f8a - Add functors to retrieve LHC conditions
• 254c3578 - fix name for namespace
• 5200ee8b - First implementation
• 6153db3d - Update functors with algorithm, to be tested
• 6ee84204 - Update functors

Compare with previous version

added 1 commit

• 3d8082d0 - Align algorithm with functor implementation

Compare with previous version

added 41 commits

• 3d8082d0...e04e8e84 - 31 commits from branch master
• 5bbefe9a - Add functors to retrieve LHC conditions
• aa54ffb8 - fix name for namespace
• 37a6e332 - First implementation
• 3f1ca2cc - Update functors with algorithm, to be tested
• 2a5ecab7 - Update functors
• 812c06da - Align algorithm with functor implementation
• f23702ad - Change strategy: use algo output as functor input
• 330c6fd3 - Fix include
• ba550a77 - Let TES handle the callable object
• f5da50c2 - Test changing output type

Compare with previous version

added 86 commits

• f5da50c2...88cfc363 - 75 commits from branch master
• 087935aa - 1 earlier commit
• 9cb2a052 - fix name for namespace
• ef0dfb02 - First implementation
• d2f1055c - Update functors with algorithm, to be tested
• f742f4b9 - Update functors
• e79b5c1d - Align algorithm with functor implementation
• 51ac29a8 - Change strategy: use algo output as functor input
• dd3e2664 - Fix include
• 47913316 - Let TES handle the callable object
• f910e61c - Test changing output type
• aea2db64 - Remove algorithm in favor of generic functor

Compare with previous version

changed the description

added 1 commit

• 15119043 - Fix rename

Compare with previous version

added 1 commit

• 559410d3 - Rename functor

Compare with previous version

added 1 commit

• 4eedaa9b - Fixed formatting

Compare with previous version

added 1 commit

• 7f7902ff - Remove init

Compare with previous version

Very nice to see the progress on this @tfulghes (and thanks @graven for the constructive advice on the implementation).

Good to see that tests is on the TODO list

changed the description

added 61 commits

• 7f7902ff...5a084c72 - 45 commits from branch master
• 5a084c72...f1cd7260 - 6 earlier commits
• 0ee2151f - Change strategy: use algo output as functor input
• 189dc9f3 - Fix include
• fa378400 - Let TES handle the callable object
• ddbe6bec - Test changing output type
• 235e3213 - Remove algorithm in favor of generic functor
• 7d31ad14 - Fix rename
• 3426c25c - Rename functor
• 5b3cb347 - Fixed formatting
• eb74b9e4 - Remove init
• 325730d6 - Remove multiple condition locations, use templated condition

Compare with previous version

added 142 commits

• 325730d6...839583fd - 126 commits from branch master
• 839583fd...f82d946a - 6 earlier commits
• 8d35af92 - Change strategy: use algo output as functor input
• db26e781 - Fix include
• 28974781 - Let TES handle the callable object
• 2897cc96 - Test changing output type
• 72df5786 - Remove algorithm in favor of generic functor
• f735134d - Fix rename
• 3a3aa8a2 - Rename functor
• aeff5ee8 - Fixed formatting
• c35d2d7a - Remove init
• b5b9296e - Remove multiple condition locations, use templated condition

Compare with previous version

added 1 commit

• a82f8bd5 - Fixed formatting

Compare with previous version

added 1 commit

• f5eef31d - Apply @graven suggestions

Compare with previous version

added 1 commit

• 8fbbe78c - Remove the _FUNCTOR definition that were used just for one instance

Compare with previous version

marked the checklist item Fix CONDITION functor as completed

mentioned in merge request DaVinci!1017 (merged)

added 1 commit

• 3afdb14b - Align the modifications in pythonic functor definition with the cpp implementation

Compare with previous version

added 1 commit

• d164f207 - Fixed formatting

Compare with previous version

marked the checklist item Add tests on DaVinci as completed

mentioned in merge request Analysis!1047 (closed)

changed the description

changed the description

added 159 commits

• d164f207...5d9ebd8b - 149 earlier commits
• a6e17d1e - add v4 decoder support back
• aeb433e2 - fix warning due to unintialized value in histo def
• b8fc8544 - remove UTNoClusterTrackMonitor
• 7ff22810 - replace std::array with HistogramArray
• 9e6d1a41 - Fixed compilation warning. This is unused as the used version of it is on line 81
• cb1cfeec - Fixed formatting
• 1732f555 - Update for muon alignment
• 40ac6967 - HasT/Velo/UT functors prefer central definition
• 2065c01d - remove obsolete functor
• 736529c5 - Code cleanup

Compare with previous version

added 231 commits

• 736529c5...8d16a08e - 230 commits from branch master
• 937d32c1 - Apply suggestion to cleanup, forcing rebase

Compare with previous version

added 1 commit

• fc0e68a2 - Remove last template

Compare with previous version

added 11 commits

• fc0e68a2...582b55b2 - 8 commits from branch master
• 83dd676e - Apply suggestion to cleanup, forcing rebase
• 154066e3 - Remove last template
• ca150f54 - replace functor Common::Condition with a more specific Detector::DeLHCb

Compare with previous version

@tfulghes, I replaced Functor::Common::Condition with a more specific Functor::Detector::DeLHCb and adapted the rest of the code (plus a rebase).

I'm confident that the code that retrieves DeLHCb from the condition slice is correct, but I cannot say much about the functor part.

requested review from @graven

approved this merge request