TrackMasterFitter: Disable material corrections with dd4hep as currently not supported

Currently not supported with dd4hep.

Closes #500 (closed)

added Tracking dd4hep labels

mentioned in merge request Moore!2563 (merged)

added 1 commit

• b21a3238 - TrackMasterFitter: Disable material corrections with dd4hep as currently not supported

Compare with previous version

• [2023-08-07 16:11] Validation started with lhcb-master-mr#8826
• [2023-08-07 16:31] Validation started with lhcb-master-mr#8827
• [2023-08-07 19:15] Validation started with lhcb-master-mr#8835
• [2023-08-08 10:18] Validation started with lhcb-master-mr#8836

added RTA label

added 1 commit

• 185ac7eb - TrackMasterFitter: Disable material corrections with dd4hep as currently not supported

Compare with previous version

added 1 commit

• 4e1b53ae - TrackMasterFitter: Disable material corrections with dd4hep as currently not supported

Compare with previous version

assigned to @jonrob

added 3 commits

• 4e1b53ae...c5beaf03 - 2 commits from branch lhcb:master
• 208fb3fc - TrackMasterFitter: Disable material corrections with dd4hep as currently not supported

Compare with previous version

merged

mentioned in commit 00a9d2f1

mentioned in merge request Alignment!414 (merged)

mentioned in issue Moore#634 (closed)

Are you sure this MR didn't disable material corrections also for parametrized scatters @jonrob ?

I could not say. Does that tool use the master fitter ?

It's inside this master fitter... you could follow the logic for m_useFastMaterialApproximation being true.

It looks to me that this needs to be fixed. A review of the MR from someone working on the track fit would've spotted this.

I don't have the time or the experience with this to look into it now, so please if you think it urgent take a look yourself.

I'll open an issue about it. We have this code review system to exactly cover for this, so let's please stick to using the standards when it comes to merges.

mentioned in issue #518