Use SciFi quarter-level cache in pattern recognition to allow proper alignment
-
Review changes -
-
Download -
Patches
-
Plain diff
The pattern recognition uses a cache to store geometric positions of the SciFi detector. The cache obtains position values from SciFi-layer objects which are not directly subject to the alignment. However, the code in the pattern recognition pretends via condition derivation that these values change with the conditions. Even worse, in reality the global z positions are simply taken from the geometry without alignment while the dxdy and dzdy are taken from a single module which is subject to alignment and then applied to the whole layer -- I consider this a bug. This set of merge requests fixes this by caching z, dxdy, dzdy by quarter which obtains these values by averaging over all modules in the quarter, i.e. takes into account the alignment. Sometimes it is still useful to use the constant positions directly from the geometry, which is provided via the layers and their lack of alignment is documented.
Preliminary tests (2022 data) show that this increases the number of reconstructed (i.e. after track fit) Long tracks by 4%
Goes with LHCb!4279 (merged), Detector!431 (merged) and Moore!2703 (merged)
Reference update mostly needed because https://gitlab.cern.ch/lhcb/Rec/-/blob/26053c8cf2c25d2d648db7f7c3920e912f059d96/Pr/PrAlgorithms/src/PrForwardTracking.cpp#L1895 rejects more VELO tracks early in the forward tracking leading to lots of counter changes.
Resolves #414 (closed)
See WP2 talk for more info on impact of this
Merge request reports
- version 54c1d92c47
- version 53ab34c067
- version 52d45712cc
- version 51b8bea34d
- version 502888f830
- version 4924337c24
- version 4815996639
- version 4772919e05
- version 461ca05ae5
- version 45b785d1b7
- version 44328647cc
- version 4327fee6f2
- version 428bfa8da8
- version 41094ee020
- version 40f8d69271
- version 39defe2ba0
- version 38d0f4c416
- version 37459296e9
- version 367d2bb16e
- version 35e9a298dc
- version 341417e079
- version 331cda8593
- version 3244c609e0
- version 3180c81b61
- version 304d50a1d0
- version 298f6fdbb4
- version 280c7fa7ca
- version 276ce0176b
- version 26e3cfbca1
- version 252fe0fbaa
- version 245b3f42b4
- version 23b35089ec
- version 229ed33451
- version 21587429da
- version 20272fd27a
- version 1958f28913
- version 187c3dbb23
- version 17026948f1
- version 16121b1df0
- version 153ec75f83
- version 14fa498893
- version 13b893b689
- version 12ccf85bce
- version 1132c793e4
- version 109edab4f7
- version 9c3d67fbf
- version 8adb3b50a
- version 7d5e4d7b7
- version 6035c1166
- version 55ab20e51
- version 487c2faab
- version 3ac1676e7
- version 28ebe4599
- version 1c47c6132
- master (base)
- latest version4142884e4 commits,
- version 54c1d92c474 commits,
- version 53ab34c0674 commits,
- version 52d45712cc4 commits,
- version 51b8bea34d4 commits,
- version 502888f8304 commits,
- version 4924337c244 commits,
- version 48159966394 commits,
- version 4772919e054 commits,
- version 461ca05ae53 commits,
- version 45b785d1b73 commits,
- version 44328647cc2 commits,
- version 4327fee6f22 commits,
- version 428bfa8da82 commits,
- version 41094ee0202 commits,
- version 40f8d692712 commits,
- version 39defe2ba02 commits,
- version 38d0f4c4162 commits,
- version 37459296e92 commits,
- version 367d2bb16e2 commits,
- version 35e9a298dc2 commits,
- version 341417e0792 commits,
- version 331cda85932 commits,
- version 3244c609e02 commits,
- version 3180c81b612 commits,
- version 304d50a1d02 commits,
- version 298f6fdbb42 commits,
- version 280c7fa7ca2 commits,
- version 276ce0176b2 commits,
- version 26e3cfbca12 commits,
- version 252fe0fbaa2 commits,
- version 245b3f42b42 commits,
- version 23b35089ec2 commits,
- version 229ed334512 commits,
- version 21587429da2 commits,
- version 20272fd27a2 commits,
- version 1958f289132 commits,
- version 187c3dbb232 commits,
- version 17026948f12 commits,
- version 16121b1df02 commits,
- version 153ec75f832 commits,
- version 14fa4988932 commits,
- version 13b893b6892 commits,
- version 12ccf85bce2 commits,
- version 1132c793e42 commits,
- version 109edab4f72 commits,
- version 9c3d67fbf2 commits,
- version 8adb3b50a2 commits,
- version 7d5e4d7b72 commits,
- version 6035c11661 commit,
- version 55ab20e511 commit,
- version 487c2faab1 commit,
- version 3ac1676e71 commit,
- version 28ebe45991 commit,
- version 1c47c61321 commit,
- Side-by-side
- Inline