RICH functors using RichPID object

Eliminate use of ProtoParticle additionalInfo for RICH functors, e.g. to be able to reduce ProtoParticle additionalInfo usage. Removes (now obsolete) use of copying RICH info to additionalInfo.

Includes separate functors for scaled versions of RichDLLe and RichDLLmu to avoid confusion in use with combined DLLs (with calo/muon).

Goes with: LHCb!4320 (merged)

fyi: @jonrob @tnanut @sberneta

related to !3596 (merged) and !3563 (closed), LHCb!4276 (closed)

added PID RICH RTA labels

@sberneta shall I add your suggestions of RICH functors here too? Then I close !3563 (closed) and LHCb!4276 (closed)

marked this merge request as draft

changed the description

added 1 commit

• c14931fb - added threshold and gas RICH functors

Compare with previous version

@mveghel That would be awesome, please go ahead!

added 24 commits

• c14931fb...2a960a42 - 22 commits from branch master
• 972bb283 - moved rich functors to use richpid obj
• f99635de - added threshold and gas RICH functors

Compare with previous version

mentioned in merge request !3563 (closed)

mentioned in merge request LHCb!4276 (closed)

marked this merge request as ready

@jonrob should I also remove filling of the now obsolete Rich additionalInfo in this MR?

mentioned in merge request LHCb!4320 (merged)

changed the description

added Event model label

added 1 commit

• 64bbdca1 - remove use of rich additional info

Compare with previous version

changed the description

mentioned in issue Moore#669 (closed)

mentioned in issue Moore#671 (closed)

added impactlow prioritymid labels

assigned to @ldufour

Thanks @mveghel - this looks good.

Could we have these functors also in the AllFunctors example at least, to illustrate how to use it? You could also consider adding it to the ParticleID FunctorCollection in case the extra_info is enabled. I understand this will trigger a ref change for DaVinci, but the Python example is important to the offline users.

TL;DR: test in DaVinci?

resolved all threads

• [2024-01-17 17:09] Validation started with lhcb-master-mr#10155
• [2024-01-17 17:25] Validation started with lhcb-master-mr#10156
• [2024-01-18 15:17] Validation started with lhcb-master-mr#10167

added 338 commits

• 64bbdca1...ac01d10d - 334 commits from branch master
• c8fa968b - moved rich functors to use richpid obj
• ac54cffa - added threshold and gas RICH functors
• 37e9286f - remove use of rich additional info
• 4682904d - fix functor test

Compare with previous version

added 1 commit

• 88201232 - remove use of rich additional info

Compare with previous version

added needs ref update label

added 1 commit

• 2f7db4c9 - remove use of rich additional info

Compare with previous version

mentioned in commit Moore@645dc107

mentioned in merge request Moore!2861 (merged)

approved this merge request

mentioned in commit Moore@e5623916

merged

mentioned in commit 65fd7c77

mentioned in commit Moore@713f08d9

mentioned in merge request !3718 (merged)

mentioned in issue Moore#688 (closed)

mentioned in commit Moore@3ea96f5f