Skip to content
Snippets Groups Projects

InteractionRegion information in additional algorithms

Merged Rosen Matev requested to merge cherry-pick-303217d7 into master

Closes #508 (closed)

This MR adds the information obtained via InteractionRegion functor to algorithms:

  • VeloKalman
  • FastPVFinder
  • PVOfflineTool
  • TrackBeamLineVertexFinder
  • KalmanFilter
  • KalmanFilterTool
  • VeloClusterTrackingSIMD

Needs LHCb!4495 (merged)

Edited by Andre Gunther

Merge request reports

Merge request pipeline #7108770 passed

Merge request pipeline passed for cd2ef16b

Merged by Andre GuntherAndre Gunther 11 months ago (Mar 23, 2024 10:04pm UTC)

Merge details

Pipeline #7110345 passed

Pipeline passed for 682a80a5 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sebastien Ponce approved this merge request

    approved this merge request

  • mentioned in issue Moore#699 (closed)

  • mentioned in issue Moore#700 (closed)

  • mentioned in issue Moore#720 (closed)

  • assigned to @gunther

  • Andre Gunther added 1 commit

    added 1 commit

    • 1744ca99 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Andre Gunther resolved all threads

    resolved all threads

  • Andre Gunther added 149 commits

    added 149 commits

    • 1744ca99...6bbccbb6 - 147 commits from branch master
    • fd99f8d2 - Merge branch 'mgiza-interaction-region-supplementary' into 'master'
    • a24f9d57 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Andre Gunther added 1 commit

    added 1 commit

    • 9657317c - Drop remaining DeVP beamspot usages

    Compare with previous version

  • Andre Gunther added 1 commit

    added 1 commit

    Compare with previous version

  • mentioned in issue Moore#730 (closed)

    • Resolved by Andre Gunther

      Looking at the changes in the code, sometimes I see that a derived conditions is added with addConditionDerivation, sometimes this is not the case. What is the reason for this?

      In VeloClusterTrackingSIMD an algorithm-specific cache location is defined here, but I did not find any cache actually being created later. Should not the location of the conditions itself be given?

      Edited by Michel De Cian
  • Andre Gunther changed the description

    changed the description

  • Andre Gunther added 24 commits

    added 24 commits

    Compare with previous version

  • Andre Gunther added 1 commit

    added 1 commit

    • 8eb053f2 - Get beamspot from InteractionRegion condition and not from DeVP

    Compare with previous version

  • Andre Gunther added 1 commit

    added 1 commit

    • fc8171b8 - Get beamspot from InteractionRegion condition and not from DeVP

    Compare with previous version

  • Andre Gunther added 1 commit

    added 1 commit

    • 19185bfe - Get beamspot from InteractionRegion condition and not from DeVP

    Compare with previous version

  • Andre Gunther
  • removed impactlow label

  • Andre Gunther mentioned in merge request LHCb!4495 (merged)

    mentioned in merge request LHCb!4495 (merged)

  • Andre Gunther changed the description

    changed the description

  • Andre Gunther added 1 commit

    added 1 commit

    • 8d790f3f - Get beamspot from InteractionRegion condition and not from DeVP

    Compare with previous version

  • Andre Gunther added 1 commit

    added 1 commit

    • e8a648da - Get beamspot from InteractionRegion condition and not from DeVP

    Compare with previous version

  • Andre Gunther
  • Andre Gunther added 5 commits

    added 5 commits

    Compare with previous version

  • Andre Gunther added 1 commit

    added 1 commit

    • cd2ef16b - Get beamspot from InteractionRegion condition and not from DeVP

    Compare with previous version

  • Andre Gunther resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading