InteractionRegion information in additional algorithms
Closes #508 (closed)
This MR adds the information obtained via InteractionRegion functor to algorithms:
VeloKalman
FastPVFinder
PVOfflineTool
TrackBeamLineVertexFinder
KalmanFilter
KalmanFilterTool
VeloClusterTrackingSIMD
Needs LHCb!4495 (merged)
Merge request reports
Activity
- Resolved by Rosen Matev
/ci-test
assigned to @rmatev
added ci-test-triggered label
- [2023-11-30 16:23] Validation started with lhcb-master-mr#9758
- [2024-01-26 09:55] Validation started with lhcb-master-mr#10261
- [2024-02-17 16:25] Validation started with lhcb-master-mr#10626
- [2024-03-17 15:01] Validation started with lhcb-master-mr#11109
- [2024-03-22 10:07] Validation started with lhcb-master-mr#11198
- [2024-03-23 10:39] Validation started with lhcb-master-mr#11214
Edited by Software for LHCbadded RTA label
added hlt1-throughput-decreased label
added impactlow priorityhigh labels
requested review from @ahennequ
- Resolved by Rosen Matev
This MR needs to be rebased to solve conflicts.
mentioned in issue Moore#688 (closed)
added 306 commits
-
27371a6a...a319bd8c - 305 commits from branch
master
- 3bb614ea - Merge branch 'mgiza-interaction-region-supplementary' into 'master'
-
27371a6a...a319bd8c - 305 commits from branch
- Resolved by Andre Gunther
/ci-test
- Resolved by Andre Gunther
mentioned in issue Moore#699 (closed)
mentioned in issue Moore#700 (closed)
- Resolved by Andre Gunther
/ci-test
mentioned in issue Moore#708 (closed)
mentioned in issue Moore#720 (closed)
- Resolved by Andre Gunther
@dovombru @mveghel (@rmatev) this is not part of %RTA/2024.03.18 yet, but is kind of essential I think. Unless
DeVP
also handles the beamspot condition correctly?
assigned to @gunther
added 149 commits
-
1744ca99...6bbccbb6 - 147 commits from branch
master
- fd99f8d2 - Merge branch 'mgiza-interaction-region-supplementary' into 'master'
- a24f9d57 - Apply 1 suggestion(s) to 1 file(s)
-
1744ca99...6bbccbb6 - 147 commits from branch
- Resolved by Andre Gunther
/ci-test
changed milestone to %Developments targeting restart after May MD
mentioned in issue Moore#730 (closed)
- Resolved by Andre Gunther
Looking at the changes in the code, sometimes I see that a derived conditions is added with
addConditionDerivation
, sometimes this is not the case. What is the reason for this?In
VeloClusterTrackingSIMD
an algorithm-specific cache location is defined here, but I did not find any cache actually being created later. Should not the location of the conditions itself be given?Edited by Michel De Cian
added 24 commits
-
7ba41090...5cf8023d - 20 commits from branch
master
- 5ee39003 - Merge branch 'mgiza-interaction-region-supplementary' into 'master'
- 0c109ef3 - Apply 1 suggestion(s) to 1 file(s)
- 52c1d0aa - Drop remaining DeVP beamspot usages
- 0d02fa25 - Fixed formatting
Toggle commit list-
7ba41090...5cf8023d - 20 commits from branch
added workaround label
added 1 commit
- 8eb053f2 - Get beamspot from InteractionRegion condition and not from DeVP
added 1 commit
- fc8171b8 - Get beamspot from InteractionRegion condition and not from DeVP
added 1 commit
- 19185bfe - Get beamspot from InteractionRegion condition and not from DeVP
- Resolved by Andre Gunther
- Resolved by Andre Gunther
removed impactlow label
mentioned in merge request LHCb!4495 (merged)
added 1 commit
- 8d790f3f - Get beamspot from InteractionRegion condition and not from DeVP
added 1 commit
- e8a648da - Get beamspot from InteractionRegion condition and not from DeVP
- Resolved by Andre Gunther
- Resolved by Andre Gunther
/ci-test LHCb!4495 (merged)
added 5 commits
-
e8a648da...32dc97be - 4 commits from branch
master
- 95674eef - Get beamspot from InteractionRegion condition and not from DeVP
-
e8a648da...32dc97be - 4 commits from branch
removed hlt1-throughput-decreased label
added 1 commit
- cd2ef16b - Get beamspot from InteractionRegion condition and not from DeVP