Fix state sets among Pr <-> v1 <-> v3 conversion (+ Add filter on CaloMatch relations)
This is best reviewed commit-wise:
-
implements a filter consuming a RelationTable the
from
relation of which are tracks new feature -
templates the PrMatchNN such that it can take v3 seed tracks as input (e.g. the output from the relation filter added in 1.)
-
contains the majority of changed files and simplifies/adapts code following LHCb!4429 (merged)'s available state locations bug fix
Click to expand
- fixes the conversion from PrSeedTrack -> v1 confusing the EndT state with LastMeasurement (this is causing Calo ref changes!)
- fixes the conversion from v1 Downstream -> v3 Downstream which ignored the BegRich1 and EndRich1 and probably caused undefined behaviour
- fixes states on PrUpstreamTracks: now the tracks actually have a state in the UT which can and is used by the PrKF avoiding unnecessary extrapolation
- fixes loss of information of Ttrack v1 -> v3 conversion
-
adds two functors working together with the relation filter, namely
GET
andMIN_ELEMENT_NOTZERO
Goes with LHCb!4429 (merged) and Allen!1433 (merged) and Moore!3045 (merged)
Throughput is not affected
Will close #519 (closed) and is related to Moore#657 (closed)
Merge request reports
Activity
assigned to @gunther
added RTA label
added 1 commit
- 58f66dbd - Template PrMatchNN to prepare v3 Ttracks input
mentioned in merge request LHCb!4429 (merged)
added 1 commit
- 8a108968 - Streamline state usage among Pr <-> v1 <-> v3 tracks
added 5 commits
-
8a108968...d83014d9 - 2 commits from branch
master
- c0777fc8 - Add PrFilter on Relations
- 56761e79 - Template PrMatchNN to prepare v3 Ttracks input
- a9daae4e - Streamline state usage among Pr <-> v1 <-> v3 tracks
Toggle commit list-
8a108968...d83014d9 - 2 commits from branch
- Resolved by Andre Gunther
added bug fix cleanup new feature labels
added 1 commit
- 88c38f5f - Streamline state usage among Pr <-> v1 <-> v3 tracks
added 1 commit
- 014638dc - Streamline state usage among Pr <-> v1 <-> v3 tracks
added 1 commit
- 97d2f3ce - Streamline state usage among Pr <-> v1 <-> v3 tracks
added 1 commit
- 9999c36e - Streamline state usage among Pr <-> v1 <-> v3 tracks
added 1 commit
- c18c5e4b - Streamline state usage among Pr <-> v1 <-> v3 tracks
added 8 commits
-
0ace7fcc...12d746c1 - 4 commits from branch
master
- fd31f65d - Add PrFilter on Relations
- 93eb6f11 - Template PrMatchNN to prepare v3 Ttracks input
- a1054ea6 - Streamline state usage among Pr <-> v1 <-> v3 tracks
- 9cb4b41f - Add Get functor and MinElementNotZero functor
Toggle commit list-
0ace7fcc...12d746c1 - 4 commits from branch
added 6 commits
-
9cb4b41f...2e409c88 - 2 commits from branch
master
- 16c57aa6 - Add PrFilter on Relations
- 8e363932 - Template PrMatchNN to prepare v3 Ttracks input
- cfccc669 - Streamline state usage among Pr <-> v1 <-> v3 tracks
- 274f40b5 - Add Get functor and MinElementNotZero functor
Toggle commit list-
9cb4b41f...2e409c88 - 2 commits from branch
added 9 commits
-
8591dc23...23c1a8e4 - 5 commits from branch
master
- 3d99ac00 - Add PrFilter on Relations
- b582c108 - Template PrMatchNN to prepare v3 Ttracks input
- 54fcd2eb - Streamline state usage among Pr <-> v1 <-> v3 tracks
- b0e363ce - Add Get functor and MinElementNotZero functor
Toggle commit list-
8591dc23...23c1a8e4 - 5 commits from branch
added 6 commits
-
8991e64a...220d8107 - 2 commits from branch
master
- 8ccf299a - Add PrFilter on Relations
- e8c58d1a - Template PrMatchNN to prepare v3 Ttracks input
- 40c46404 - Streamline state usage among Pr <-> v1 <-> v3 tracks
- 306b255b - Add Get functor and MinElementNotZero functor
Toggle commit list-
8991e64a...220d8107 - 2 commits from branch
mentioned in merge request Allen!1433 (merged)
- Resolved by Andre Gunther
/ci-test LHCb!4429 (merged) Allen!1433 (merged)
added ci-test-triggered label
- [2024-02-09 09:48] Validation started with lhcb-master-mr#10479
- [2024-02-11 16:25] Validation started with lhcb-master-mr#10516
- [2024-02-11 19:27] Validation started with lhcb-master-mr#10519
- [2024-02-13 10:59] Validation started with lhcb-master-mr#10548
- [2024-02-13 16:29] Validation started with lhcb-master-mr#10556
- [2024-02-15 07:38] Validation started with lhcb-master-mr#10586
- [2024-02-15 18:15] Validation started with lhcb-master-mr#10597
- [2024-02-18 19:18] Validation started with lhcb-master-mr#10632
- [2024-02-21 16:25] Automatic merge failed in [lhcb-master-mr#10679](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-master-mr/10679/Rec/checkout
- [2024-02-22 10:09] Validation started with lhcb-master-mr#10685
- [2024-02-26 12:03] Validation started with lhcb-master-mr#10728
- [2024-02-26 12:38] Validation started with lhcb-master-mr#10733
- [2024-04-12 12:00] Validation started with lhcb-2024-patches-mr#48
- [2024-04-15 16:22] Validation started with lhcb-2024-patches-mr#88
- [2024-04-23 11:52] Validation started with lhcb-2024-patches-mr#181
- [2024-04-24 10:48] Validation started with lhcb-2024-patches-mr#204
- [2024-04-25 11:32] Validation started with lhcb-2024-patches-mr#228
- [2024-04-28 14:02] Validation started with lhcb-2024-patches-mr#268
- [2024-04-29 10:17] Validation started with lhcb-2024-patches-mr#276
- [2024-04-30 09:54] Validation started with lhcb-2024-patches-mr#296
- [2024-05-24 13:00] Validation started with lhcb-2024-patches-mr#544
- [2024-05-24 19:39] Validation started with lhcb-2024-patches-mr#550
Edited by Software for LHCbadded 12 commits
-
2c397751...844b5d47 - 8 commits from branch
master
- 0d886b7a - Add PrFilter on Relations
- fc83e233 - Template PrMatchNN to prepare v3 Ttracks input
- 1e90c323 - Streamline state usage among Pr <-> v1 <-> v3 tracks
- ffdebc74 - Add Get functor and MinElementNotZero functor
Toggle commit list-
2c397751...844b5d47 - 8 commits from branch
added 1 commit
- 5f06d934 - Add Get functor and MinElementNotZero functor